Should no-longer be needed post #27872. If it is, then suppress-external-warnings should be fixed.
refactor: remove in-code warning suppression #28002
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:in_code_warn_suppress changing 3 files +0 −25-
fanquake commented at 1:55 PM on June 29, 2023: member
-
3210f224db
refactor: remove in-code warning suppression
Should no-longer be needed post #27872. If it is, then suppress-external-warnings should be fixed.
-
DrahtBot commented at 1:55 PM on June 29, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK hebasto If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Refactoring on Jun 29, 2023
- DrahtBot added the label CI failed on Jun 29, 2023
- hebasto approved
-
hebasto commented at 7:15 PM on June 29, 2023: member
ACK 3210f224dbeaf0f9de09d4e83c3e6666128a6717
- DrahtBot removed the label CI failed on Jun 29, 2023
- fanquake merged this on Jun 30, 2023
- fanquake closed this on Jun 30, 2023
- fanquake deleted the branch on Jun 30, 2023
- sidhujag referenced this in commit 7e37006ba6 on Jun 30, 2023
- bitcoin locked this on Jun 29, 2024
Labels