ci: re-enable gui tests for s390x #28014

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:s390x_re_enable_gui_tests changing 1 files +1 −1

fanquake commented at 10:37 AM on June 30, 2023: member

These work for me now. If they still don't work in other setups, maybe we can better document the issues.

time FILE_ENV="./ci/test/00_setup_env_s390x.sh" ./ci/test_run_all.sh
...
Running tests: coins_tests from test/coins_tests.cpp
PASS: qt/test/test_bitcoin-qt
Running tests: coinstatsindex_tests from test/coinstatsindex_tests.cpp
...
Stop and remove CI container by ID
+ docker container kill 617bef8accb87530e5fbb03ff07b3b9f0aa9e3030d4da424c9612d153ab98dbf
617bef8accb87530e5fbb03ff07b3b9f0aa9e3030d4da424c9612d153ab98dbf

real	51m37.809s

ci: re-enable gui tests for s390x

These work for me now. If they still don't work in other setups,
maybe we can better document the issues.

```bash
time FILE_ENV="./ci/test/00_setup_env_s390x.sh" ./ci/test_run_all.sh
...
Running tests: coins_tests from test/coins_tests.cpp
PASS: qt/test/test_bitcoin-qt
Running tests: coinstatsindex_tests from test/coinstatsindex_tests.cpp
...
Stop and remove CI container by ID
+ docker container kill 617bef8accb87530e5fbb03ff07b3b9f0aa9e3030d4da424c9612d153ab98dbf
617bef8accb87530e5fbb03ff07b3b9f0aa9e3030d4da424c9612d153ab98dbf

real	51m37.809s
```

9be4565c2d

DrahtBot commented at 10:37 AM on June 30, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK MarcoFalke, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Jun 30, 2023
maflcko commented at 10:56 AM on June 30, 2023: member

lgtm ACK 9be4565c2db6d7a420d032d5c41843d473ed32d1 , didn't test
hebasto approved
hebasto commented at 1:48 PM on June 30, 2023: member

ACK 9be4565c2db6d7a420d032d5c41843d473ed32d1, tested on Ubuntu 23.04.
fanquake merged this on Jun 30, 2023
fanquake closed this on Jun 30, 2023
fanquake deleted the branch on Jun 30, 2023
sidhujag referenced this in commit 571e709891 on Jun 30, 2023
TheCharlatan commented at 7:24 PM on June 30, 2023: contributor

Post-merge ACK 9be4565c2db6d7a420d032d5c41843d473ed32d1
bitcoin locked this on Jun 29, 2024

Type	Reviewers
ACK	MarcoFalke, hebasto

Contributors

Labels

ci: re-enable gui tests for s390x #28014

Reviews