Behaves better if abnormal issues occur
Fix issues in ZMQ error handling #28029
pull luke-jr wants to merge 3 commits into bitcoin:master from luke-jr:fix_zmq_errhandling_202307 changing 2 files +11 −16-
luke-jr commented at 6:01 PM on July 4, 2023: member
-
351ae1ee4e
Bugfix: ZMQ: Leave notifiers intact rather than shut them down if they fail a notification once
Whatever the cause of the failure, it makes more sense to keep trying rather than kill the notifier entirely
-
Bugfix: ZMQ: Don't try to use zmq_strerror when reading block from disk fails 4eaa827b91
-
ZMQ: If reading block from disk fails, log the block hash 07086589b2
-
DrahtBot commented at 6:01 PM on July 4, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
- luke-jr referenced this in commit 11269eeb1d on Aug 16, 2023
- luke-jr referenced this in commit 0da60f9d7c on Aug 16, 2023
- luke-jr referenced this in commit 614c144aa0 on Aug 16, 2023
-
fanquake commented at 12:32 PM on August 17, 2023: member
Behaves better if abnormal issues occur
Can you elaborate at all? I assume this is something that occured in production?
cc @instagibbs. Might be interested in reviewing?
- DrahtBot added the label CI failed on Oct 25, 2023
-
maflcko commented at 11:31 AM on October 25, 2023: member
Can be marked as draft, while it is waiting on the author?
-
DrahtBot commented at 1:08 AM on April 7, 2024: contributor
<!--2e250dc3d92b2c9115b66051148d6e47-->
🤔 There hasn't been much activity lately and the CI seems to be failing.
If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.
-
achow101 commented at 2:47 PM on April 9, 2024: member
The PR didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open PRs.
Closing due to lack of interest.
- achow101 closed this on Apr 9, 2024
- bitcoin locked this on Apr 9, 2025
