fuzz: use `ConnmanTestMsg` in `connman` #28091

pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2023-07-connman-mnodes changing 1 files +9 −1

brunoerg commented at 2:24 PM on July 17, 2023: contributor

Fixes #27980

Using ConnmanTestMsg we can add nodes and be more effective fuzzing functions like DisconnectNode, FindNode, GetNodeStats and other ones.
DrahtBot commented at 2:24 PM on July 17, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK MarcoFalke, dergoegge

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Jul 17, 2023
maflcko commented at 3:15 PM on July 17, 2023: member

lgtm ACK d9bd559638b453b8c6e03e34005ad5c52099b6bf

Type	Reviewers
ACK	MarcoFalke, dergoegge

fuzz: use `ConnmanTestMsg` in `connman`

Using `ConnmanTestMsg` we can add nodes and be
more effective fuzzing functions like `DisconnectNode`,
`FindNode`, `GetNodeStats` and other ones.

ecfe507e07

in src/test/fuzz/connman.cpp:45 in d9bd559638 outdated
```
  40 | @@ -41,6 +41,13 @@ FUZZ_TARGET(connman, .init = initialize_connman)
  41 |      CNode random_node = ConsumeNode(fuzzed_data_provider);
  42 |      CSubNet random_subnet;
  43 |      std::string random_string;
  44 | +
  45 | +    LOCK(NetEventsInterface::g_msgproc_mutex);
```
maflcko commented at 9:29 AM on July 22, 2023:

Any reason for this?

brunoerg commented at 1:39 PM on July 22, 2023:

Isn't this required to use ConnmanTestMsg?

maflcko commented at 2:28 PM on July 22, 2023:

Yeah, I am asking for the compiler warning when it is removed, or the method that requires it. Am I missing something?

brunoerg commented at 4:42 PM on July 22, 2023:

In fact, since we're using only AddTestNode I think that it's not required. Going to remove it..
brunoerg force-pushed on Jul 22, 2023
maflcko commented at 9:49 AM on July 28, 2023: member

review ACK ecfe507e07e9bdab210e04ebd3fc3b8ae9d6a094

Didn't test anything nor compile
brunoerg commented at 1:47 PM on July 28, 2023: contributor

friendly ping: @dergoegge
dergoegge approved
dergoegge commented at 8:53 AM on July 31, 2023: member

utACK ecfe507e07e9bdab210e04ebd3fc3b8ae9d6a094
fanquake merged this on Jul 31, 2023
fanquake closed this on Jul 31, 2023
sidhujag referenced this in commit b428e3c7cd on Aug 9, 2023
bitcoin locked this on Jul 30, 2024

Contributors

Labels