contrib: move user32.dll from bitcoind.exe libs #28099

fanquake commented at 3:40 PM on July 18, 2023: member

The user interface library is no-longer needed by bitcoind.exe, or utils, only bitcoin-qt.exe. Add missing doc.

contrib: move user32.dll from bitcoind.exe libs

The user interface library is no-longer needed by `bitcoind.exe`,
or utils, only `bitcoin-qt.exe`.
Add missing lib doc.

8c38509233

fanquake added the label DrahtBot Guix build requested on Jul 18, 2023

DrahtBot commented at 3:40 PM on July 18, 2023: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

fanquake force-pushed on Jul 18, 2023

hebasto commented at 4:18 PM on July 18, 2023: member

Concept ACK.

DrahtBot commented at 7:45 AM on July 19, 2023: contributor

Guix builds

File	commit c6a338b67e8e7848e6f42329a8b0bf3add16ad51<br>(master)	commit afa77f9075aae0c7466c2cb88c2bec7ee18e5e8a<br>(master and this pull)
SHA256SUMS.part	`c72a3f23d53aa990...`	`678128ca88d3b104...`
*-aarch64-linux-gnu-debug.tar.gz	`986afaaa56527871...`	`c4a617372ce894ce...`
*-aarch64-linux-gnu.tar.gz	`305252750930e3f0...`	`24fc0ded3a83d807...`
*-arm-linux-gnueabihf-debug.tar.gz	`218aee5747027117...`	`c179ca557c0cdce9...`
*-arm-linux-gnueabihf.tar.gz	`861402d871153f46...`	`9d81f815838e3019...`
*-arm64-apple-darwin-unsigned.dmg	`a1bc01e3835268d4...`	`623b27631d1ba38a...`
*-arm64-apple-darwin-unsigned.tar.gz	`e8e4c9c4900b497a...`	`8e70a967eb69d7b5...`
*-arm64-apple-darwin.tar.gz	`9735acf86beb0af1...`	`28f3f9d9e42951dd...`
*-powerpc64-linux-gnu-debug.tar.gz	`2995a8798b2e7ba0...`	`5e4338e3e6021e24...`
*-powerpc64-linux-gnu.tar.gz	`4c9af9fa59e03a09...`	`d4a4b6a25af186da...`
*-powerpc64le-linux-gnu-debug.tar.gz	`c263b7bd85a0af75...`	`7d605a8a0c92458b...`
*-powerpc64le-linux-gnu.tar.gz	`65ae59cafabeee11...`	`840d570266b25467...`
*-riscv64-linux-gnu-debug.tar.gz	`d05cf39b296c85c4...`	`51e1e17897871e9b...`
*-riscv64-linux-gnu.tar.gz	`5ec809b0cc64efaf...`	`591f4b4ef45dd9db...`
*-x86_64-apple-darwin-unsigned.dmg	`752982f0a053e7b9...`	`f523cfbed20a8b07...`
*-x86_64-apple-darwin-unsigned.tar.gz	`2fdf701d22825740...`	`149ed4a54ac3d09e...`
*-x86_64-apple-darwin.tar.gz	`e00500ba2aef4d65...`	`af283950755491ac...`
*-x86_64-linux-gnu-debug.tar.gz	`3c99e7af986c8496...`	`00f11050acc98dec...`
*-x86_64-linux-gnu.tar.gz	`dc58566ed872bcb7...`	`0c031fab1b2071fc...`
*.tar.gz	`f0ab2835643677db...`	`07d93ac80504f01f...`
guix_build.log	`af55ed9bdcfc52e9...`	`27a53472ccd79d01...`
guix_build.log.diff		`a8bea98153d7cbc3...`

DrahtBot removed the label DrahtBot Guix build requested on Jul 19, 2023

DrahtBot added the label Scripts and tools on Jul 19, 2023

hebasto approved

hebasto commented at 8:43 AM on July 19, 2023: member

ACK 8c3850923300352f14dc3dde6a6ce6689ddef185, I've verified imported libraries on a Windows machine with the dumpbin /imports command.

Guix build:

f1a74cd08c886713c7d1ea90ff0119aa227f3cec21a35a68943357cc70dbe658  guix-build-8c3850923300/output/dist-archive/bitcoin-8c3850923300.tar.gz
8d1777279d231b0b85251194b7cc872d197f2c41df6dc053791f9be80d3b9523  guix-build-8c3850923300/output/x86_64-w64-mingw32/SHA256SUMS.part
b78e0f599553ce238dffe810984449a346e842d9fe16ab4b9231612089f5c717  guix-build-8c3850923300/output/x86_64-w64-mingw32/bitcoin-8c3850923300-win64-debug.zip
6abdffa572fd9dfb968f8f49a92acb349bd0ac979efa3ca83ee33c8d2e01bad8  guix-build-8c3850923300/output/x86_64-w64-mingw32/bitcoin-8c3850923300-win64-setup-unsigned.exe
e8dca5ec6476e468415cd571e59a47f5168ffa65769b9d21de98ed4d17a02061  guix-build-8c3850923300/output/x86_64-w64-mingw32/bitcoin-8c3850923300-win64-unsigned.tar.gz
e8bf93e54e66a8ec2f49b4d59b64e053a1d537a1cc61e9072fe9a80f7103b38a  guix-build-8c3850923300/output/x86_64-w64-mingw32/bitcoin-8c3850923300-win64.zip

A suggestion for a follow-up is to reconsider library searching in: https://github.com/bitcoin/bitcoin/blob/c6a338b67e8e7848e6f42329a8b0bf3add16ad51/configure.ac#L685-L701

However, it is might be postponed until switching to the upcoming CMake-based build system.

fanquake merged this on Jul 20, 2023

fanquake closed this on Jul 20, 2023

fanquake deleted the branch on Jul 20, 2023

sidhujag referenced this in commit eb11d1e400 on Jul 21, 2023

bitcoin locked this on Jul 19, 2024