win: non-static libssp in libbitcoinconsensus DLL #28104

issue fanquake opened this issue on July 19, 2023

fanquake commented at 11:18 AM on July 19, 2023: member

If you Guix build for Windows, and call objdump on libbitcoinconsensus-0.dll, you'll find it uses a non-static libssp:

objdump -x src/.libs/libbitcoinconsensus-0.dll
...
The Import Tables (interpreted .idata section contents)
 vma:            Hint    Time      Forward  DLL       First
                 Table   Stamp     Chain    Name      Thunk
 00263000	00263050 00000000 00000000 0026409c 00263490

	DLL Name: libssp-0.dll
	vma:  Hint/Ord Member-Name Bound-To
	2638d0	    3  __memcpy_chk
	2638e0	    7  __stack_chk_fail
	2638f4	    8  __stack_chk_guard

DLLs should be built with a static libgcc/stdc++/ssp:

https://github.com/bitcoin/bitcoin/blob/84c5416b03248c91aa7efe46555699f9f121d8a4/configure.ac#L724-L730

This has been an issue since we switched to using Guix for the 22.0 release.

fanquake added the label Windows on Jul 19, 2023
fanquake added the label Build system on Jul 19, 2023
fanquake closed this on Nov 22, 2023
Julio-Rats referenced this in commit 5d13b9586e on Jan 26, 2024
bitcoin locked this on Nov 21, 2024

Contributors

fanquake

Labels

Windows Build system

Linked (view graph)

#28461 build: Windows SSP roundup