doc: Clarify that -fstack-reuse=all bugs exist on all versions of GCC #28105

1. 
   maflcko commented at 11:27 AM on July 19, 2023: member

   This is a follow-up to commit 7b850bc2a1cd8547a2dbb5a18173f53439601220. While the test case no longer reproduces, the general class of -fstack-reuse bugs still exists in all versions of GCC. The workaround can never be removed, unless the whole class of bugs is fixed.

2. 
   DrahtBot commented at 11:27 AM on July 19, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Docs on Jul 19, 2023
4. 
   fanquake commented at 3:55 PM on August 1, 2023: member

   I see the commentary on the GCC bug, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90348#c30, that someone claims the issue still exists, but the test-case no-longer works. Should we add a note to our test case to note that it's no-longer useful post GCC 12?

5. 
   maflcko commented at 3:59 PM on August 1, 2023: member

   It may be better to replace it with one that still reproduces. Though, there is an array of at least 5 of those bugs, presumably all due to the same underlying GCC bug. Instead of constantly updating the test case to the latest one that still reproduces, maybe just remove the outdated test case?

6. maflcko added this to the milestone 26.0 on Aug 1, 2023
7. 
   maflcko commented at 11:37 AM on September 12, 2023: member

   Going to leave code/test changes to a follow-up, to focus on the docs only in this pull.

8. doc: Clarify that -fstack-reuse=all bugs exist on all versions of GCC fabb419a3c
9. maflcko force-pushed on Sep 12, 2023
10. 
    maflcko commented at 11:42 AM on September 12, 2023: member

    Should we add a note to our test case to note that it's no-longer useful post GCC 12?

    Good idea, done.

11. fanquake approved
12. 
    fanquake commented at 1:19 PM on September 12, 2023: member

    ACK fabb419a3caafc00fbbc533fee14fab7a5d2a2c6

13. fanquake merged this on Sep 12, 2023
14. fanquake closed this on Sep 12, 2023

    ---

15. maflcko deleted the branch on Sep 12, 2023
16. Frank-GER referenced this in commit 66dd98595f on Sep 19, 2023
17. bitcoin locked this on Sep 11, 2024

Milestone
26.0