suppressions: note that `type:ClassName::MethodName` should be used #28147

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:suppressions_class_func changing 1 files +3 −6
  1. fanquake commented at 12:33 PM on July 25, 2023: member

    Now that the symbolizer is back in play, suppressions can once-again be targeted to functions, rather than file-wide.

  2. suppressions: note that 'type:ClassName::MethodName' should be used
    Now that the symbolizer is back in play, suppressions can once-again be
    targeted to functions, rather than file-wide.
    d0c6cc4abe
  3. DrahtBot commented at 12:34 PM on July 25, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK MarcoFalke, hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. maflcko commented at 12:43 PM on July 25, 2023: member

    lgtm ACK d0c6cc4abe42163aaf081a969d2c449785563ba2

  5. hebasto approved
  6. hebasto commented at 9:22 PM on July 25, 2023: member

    ACK d0c6cc4abe42163aaf081a969d2c449785563ba2

  7. fanquake merged this on Jul 26, 2023
  8. fanquake closed this on Jul 26, 2023

  9. fanquake deleted the branch on Jul 26, 2023
  10. sidhujag referenced this in commit 41341f05a1 on Aug 9, 2023
  11. maflcko commented at 9:18 PM on November 1, 2023: member

    Not sure why the symbolizer doesn't work on Fedora, but I guess this should be reverted? Steps to reproduce on a fresh install of Fedora 39:

    dnf install gcc-c++ libtool make autoconf automake python3 clang llvm libcxx-devel libcxxabi-devel git ccache libevent-devel boost-devel -y && git clone https://github.com/bitcoin/bitcoin.git  --depth=1 ./bitcoin-core && cd bitcoin-core &&  ./autogen.sh &&   ./configure CC=clang CXX=clang++ --with-sanitizers=fuzzer,integer,undefined --enable-fuzz && make -j $(nproc) && ./test/fuzz/test_runner.py -j 1 -l DEBUG /tmp/empty_folder/ addition_overflow
    
    Run addition_overflow with args ['/bitcoin-core/src/test/fuzz/fuzz', '-runs=1', PosixPath('/tmp/empty_folder/addition_overflow')]INFO: Running with entropic power schedule (0xFF, 100).
    INFO: Seed: 2274899552
    INFO: Loaded 1 modules   (426135 inline 8-bit counters): 426135 [0x55b591c25f98, 0x55b591c8e02f), 
    INFO: Loaded 1 PC tables (426135 PCs): 426135 [0x55b591c8e030,0x55b59230e9a0), 
    INFO:        0 files found in /tmp/empty_folder/addition_overflow
    INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 4096 bytes
    test/fuzz/FuzzedDataProvider.h:212:47: runtime error: unsigned integer overflow: 9223372036854775807 - 9223372036854775808 cannot be represented in type 'uint64_t' (aka 'unsigned long')
        [#0](/bitcoin-bitcoin/0/) 0x55b5900cc028  (/bitcoin-core/src/test/fuzz/fuzz+0x121e028) (BuildId: 306b8873f90b44941bafa8f0ae2b1a11c835d541)
        [#1](/bitcoin-bitcoin/1/) 0x55b5900c7778  (/bitcoin-core/src/test/fuzz/fuzz+0x1219778) (BuildId: 306b8873f90b44941bafa8f0ae2b1a11c835d541)
        [#2](/bitcoin-bitcoin/2/) 0x55b590492f86  (/bitcoin-core/src/test/fuzz/fuzz+0x15e4f86) (BuildId: 306b8873f90b44941bafa8f0ae2b1a11c835d541)
        [#3](/bitcoin-bitcoin/3/) 0x55b590081e34  (/bitcoin-core/src/test/fuzz/fuzz+0x11d3e34) (BuildId: 306b8873f90b44941bafa8f0ae2b1a11c835d541)
        [#4](/bitcoin-bitcoin/4/) 0x55b590082be1  (/bitcoin-core/src/test/fuzz/fuzz+0x11d4be1) (BuildId: 306b8873f90b44941bafa8f0ae2b1a11c835d541)
        [#5](/bitcoin-bitcoin/5/) 0x55b590082fd6  (/bitcoin-core/src/test/fuzz/fuzz+0x11d4fd6) (BuildId: 306b8873f90b44941bafa8f0ae2b1a11c835d541)
        [#6](/bitcoin-bitcoin/6/) 0x55b59006ffec  (/bitcoin-core/src/test/fuzz/fuzz+0x11c1fec) (BuildId: 306b8873f90b44941bafa8f0ae2b1a11c835d541)
        [#7](/bitcoin-bitcoin/7/) 0x55b59009c556  (/bitcoin-core/src/test/fuzz/fuzz+0x11ee556) (BuildId: 306b8873f90b44941bafa8f0ae2b1a11c835d541)
        [#8](/bitcoin-bitcoin/8/) 0x7fc722965149  (/lib64/libc.so.6+0x28149) (BuildId: 7dd93cb9991a89f0ec53d9443a0b78ad952269bc)
        [#9](/bitcoin-bitcoin/9/) 0x7fc72296520a  (/lib64/libc.so.6+0x2820a) (BuildId: 7dd93cb9991a89f0ec53d9443a0b78ad952269bc)
        [#10](/bitcoin-bitcoin/10/) 0x55b590064ba4  (/bitcoin-core/src/test/fuzz/fuzz+0x11b6ba4) (BuildId: 306b8873f90b44941bafa8f0ae2b1a11c835d541)
    
    SUMMARY: UndefinedBehaviorSanitizer: unsigned-integer-overflow test/fuzz/FuzzedDataProvider.h:212:47 in 
    MS: 0 ; base unit: 0000000000000000000000000000000000000000
    
    
    artifact_prefix='./'; Test unit written to ./crash-da39a3ee5e6b4b0d3255bfef95601890afd80709
    
  12. maflcko commented at 3:11 PM on November 6, 2023: member

    Same on OpenSuse Tumbleweed:

    zypper in -y libevent-devel boost-devel awk find bison gcc-c++ libtool make autoconf automake python3 clang llvm lbzip2 patch xz curl wget htop git vim ccache && git clone https://github.com/bitcoin/bitcoin.git --depth=1 ./bitcoin-core && cd bitcoin-core && ./autogen.sh && ./configure CC=clang CXX=clang++ --with-sanitizers=fuzzer,integer,undefined --enable-fuzz && make -j $(nproc) && ./test/fuzz/test_runner.py -j 1 -l DEBUG /tmp/empty_folder/ addition_overflow

  13. fanquake referenced this in commit f018582f1a on Nov 7, 2023
  14. fanquake referenced this in commit 48288d3829 on Nov 7, 2023
  15. fanquake referenced this in commit 00b78a2dde on Nov 7, 2023
  16. fanquake referenced this in commit 809c9474e1 on Nov 7, 2023
  17. fanquake referenced this in commit e21c74d522 on Nov 7, 2023
  18. fanquake referenced this in commit 87d6d697df on Nov 7, 2023
  19. fanquake referenced this in commit 74215a1534 on Nov 7, 2023
  20. fanquake referenced this in commit 49d953281d on Nov 7, 2023
  21. fanquake referenced this in commit b5d8f001a8 on Nov 8, 2023
  22. bitcoin locked this on Nov 5, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 12:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me