qa, doc: Fix comment #28181

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:230729-doc changing 1 files +2 −2

hebasto commented at 11:48 AM on July 29, 2023: member
This PR is a follow-up for:
- #9956
- https://github.com/bitcoin/bitcoin/pull/10096
DrahtBot commented at 11:48 AM on July 29, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK RandyMcMillan

Concept ACK kevkevinpal

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label CI failed on Jul 29, 2023
kevkevinpal commented at 12:39 AM on July 30, 2023: contributor

Concept ACK 011c77d

Type	Reviewers
ACK	RandyMcMillan
Concept ACK	kevkevinpal

in test/functional/test_runner.py:786 in 011c77dd8d outdated

 783 | @@ -784,7 +784,7 @@ def check_script_list(*, src_dir, fail_on_warn):
 784 |      """Check scripts directory.
 785 |  
 786 |      Check that there are no scripts in the functional tests directory which are

maflcko commented at 7:18 AM on July 30, 2023:

    Check that there all python files in this directory are categorized as a test script or meta script.

hebasto commented at 8:58 AM on July 30, 2023:

Thanks! Updated.

maflcko approved
hebasto force-pushed on Jul 30, 2023

qa, doc: Fix comment

This change is a follow-up for:
- https://github.com/bitcoin/bitcoin/pull/9956
- https://github.com/bitcoin/bitcoin/pull/10096

ab498d913c

in test/functional/test_runner.py:786 in e671616841 outdated

 782 | @@ -783,8 +783,8 @@ def check_script_prefixes():
 783 |  def check_script_list(*, src_dir, fail_on_warn):
 784 |      """Check scripts directory.
 785 |  
 786 | -    Check that there are no scripts in the functional tests directory which are
 787 | -    not being run by pull-tester.py."""
 788 | +    Check that there all python files in this directory are categorized

fanquake commented at 10:09 AM on July 30, 2023:

    Check that all python files in this directory are categorized

hebasto commented at 10:11 AM on July 30, 2023:

Done.

hebasto force-pushed on Jul 30, 2023
RandyMcMillan commented at 10:56 AM on July 30, 2023: contributor

ACK ab498d913c6f9f6096c75cc43a91e7a12cfc3fb7
DrahtBot removed the label CI failed on Jul 30, 2023
fanquake merged this on Jul 31, 2023
fanquake closed this on Jul 31, 2023
hebasto deleted the branch on Aug 1, 2023
sidhujag referenced this in commit 2f2be2903b on Aug 9, 2023
bitcoin locked this on Jul 31, 2024

Contributors

Linked (view graph)

#9956 Reorganise qa directory #10096 Check that all test scripts in test/functional are being run

qa, doc: Fix comment #28181

Reviews