Probably should include doc/ contrib/ etc like the zip/linux tars do too.
setup.nsi doesnt include full sources, only src directory #2819
issue TheBlueMatt opened this issue on July 9, 2013-
TheBlueMatt commented at 1:54 PM on July 9, 2013: member
-
gavinandresen commented at 8:15 PM on July 9, 2013: contributor
I think we should go the opposite way, and not ship any sources with the Windows setup.exe.
My rationale: nobody is getting the setup.exe and then building from source
-
jgarzik commented at 8:42 PM on July 9, 2013: contributor
@gavinandresen ACK
-
TheBlueMatt commented at 8:58 PM on July 9, 2013: member
Fine by me, probably shouldnt include partial sources, though.
-
sipa commented at 9:08 PM on July 9, 2013: member
Agree about not including the sources in the Windows zip/install, but we should include the documents, which is what this issue is about.
-
laanwj commented at 6:17 AM on July 10, 2013: member
Right it's the wrong way around, it should include the docs but not the source, now it includes the source but not the docs.
-
Diapolo commented at 11:15 AM on July 12, 2013: none
What I like about inclusion of the src is I can easily do a diff between my current version and a new version and see changes in source. Perhaps I'm the only Win-user doing this ;).
- laanwj referenced this in commit abb6774f12 on Jan 21, 2014
- laanwj referenced this in commit 6c980c7d31 on Jan 21, 2014
- laanwj closed this on Jan 23, 2014
- MathyV referenced this in commit 3141799983 on Aug 5, 2014
- Bushstar referenced this in commit 377dd3b822 on Apr 5, 2019
- Bushstar referenced this in commit 8c58799d8d on Apr 8, 2020
- MarcoFalke locked this on Sep 8, 2021
