doc: remove Fedora libdb4-*-devel install docs #28231

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:fedora_drop_legacy_bdb_install changing 1 files +2 −6

fanquake commented at 12:21 PM on August 7, 2023: member

These are no-longer installable on any recent Fedora (last working version was 32). Remove the install instructions, and consolidate this section to be the same as the Ubuntu & Debian BDB install instructions.
DrahtBot commented at 12:21 PM on August 7, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK MarcoFalke

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Docs on Aug 7, 2023
in doc/build-unix.md:118 in e0e247ad1e outdated
```
 110 | @@ -111,14 +111,10 @@ SQLite is required for the descriptor wallet:
 111 |  
 112 |      sudo dnf install sqlite-devel
 113 |  
 114 | -Berkeley DB is required for the legacy wallet:
 115 | -
 116 | -    sudo dnf install libdb4-devel libdb4-cxx-devel
 117 | -
 118 | -Berkeley DB is only required for the legacy wallet. Newer Fedora releases have only `libdb-devel` and `libdb-cxx-devel` packages, but these will install
```
maflcko commented at 12:31 PM on August 7, 2023:

Not sure about the formatting change and replacing "Fedora" with "Ubuntu". But removing the dnf install seems fine.

fanquake commented at 12:33 PM on August 7, 2023:

The formatting is the same as the above (hence the typo). Will fixup.

maflcko commented at 12:40 PM on August 7, 2023:

This is still wrong. Also, I am not sure why the formatting of a section that is about to be removed needs to change at all. Just leave it as-is?

maflcko commented at 12:44 PM on August 7, 2023:

Ok, I see dnf actually installs 5.3 and not 5.1. It would be better to mention such changes in the message instead of claiming the section is the "same" as Ubuntu.

maflcko commented at 12:46 PM on August 7, 2023:

Nvm my previous comment, it is still wrong. You are changing 5.3 to 5.1 for no reason (not the other way round).

Would be better to just leave the section as-is, unless there is a reason to change something.

fanquake commented at 12:49 PM on August 7, 2023:

I didn't see an issue with consolidating it to be the same as another identical section. In any case, no more fomatting changes, and fixed the typo in the Ubuntu/Debian section.
maflcko changes_requested
fanquake force-pushed on Aug 7, 2023

Type	Reviewers
ACK	MarcoFalke

doc: remove Fedora libdb4-*-devel install docs

These are no-longer installable on any recent Fedora (33+).
Remove the install instructions.
Fix the typo in the Ubuntu/Debian instructions.

11a499eb4d

fanquake force-pushed on Aug 7, 2023
maflcko commented at 3:14 PM on August 7, 2023: member

lgtm ACK 11a499eb4d57f2c5eabd7955bcc7e419364b3194
fanquake merged this on Aug 7, 2023
fanquake closed this on Aug 7, 2023
fanquake deleted the branch on Aug 7, 2023
sidhujag referenced this in commit 453b005b18 on Aug 9, 2023
bitcoin locked this on Aug 6, 2024

Contributors

Labels

doc: remove Fedora libdb4-*-devel install docs #28231

Reviews