ci: Refactor: Remove CI_USE_APT_INSTALL #28278

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2308-ci-cleanup- changing 3 files +5 −7

maflcko commented at 12:41 PM on August 16, 2023: member
Seems odd to use CI_USE_APT_INSTALL == no as an alias for CI_OS_NAME == macos. Fix this by removing the alias.

Also, for github CI:
- restore MAKEJOBS to the same value as in cirrus.yml.
- remove cirrus-only PACKAGE_MANAGER_INSTALL.
- remove redundant TEST_RUNNER_TIMEOUT_FACTOR
- Add M1 link
DrahtBot commented at 12:41 PM on August 16, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Aug 16, 2023
hebasto approved
hebasto commented at 1:30 PM on August 16, 2023: member

ACK fa04623bbb284b35b27b2575b217341ab2e81e48.

Thank you!
hebasto commented at 9:36 AM on August 17, 2023: member
Maybe also address the following comments:
- #28187 (review)
- #28187 (review)
in this PR?
DrahtBot added the label CI failed on Aug 17, 2023
ci: Refactor: Remove CI_USE_APT_INSTALL fa26387769
maflcko force-pushed on Aug 17, 2023
hebasto approved
hebasto commented at 12:36 PM on August 17, 2023: member

ACK fa263877691a7babb08a83f5f977390a0ba64729.

nit: the commit message has lost some details.
maflcko commented at 12:40 PM on August 17, 2023: member

nit: the commit message has lost some details.

I will copy-paste the pull request description if I have to push again
fanquake merged this on Aug 17, 2023
fanquake closed this on Aug 17, 2023
maflcko deleted the branch on Aug 17, 2023
sidhujag referenced this in commit 28bf821942 on Aug 17, 2023
pinheadmz commented at 12:38 PM on October 3, 2023: member

M1 now available in GH actions: https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/
maflcko commented at 12:40 PM on October 3, 2023: member

M1 now available in GH actions: https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/

It is commercial-only:

With today’s launch, our macOS larger runners will be priced at $0.16/minute for XL and $0.12/minute for large.
bitcoin locked this on Dec 3, 2024

Type	Reviewers
ACK	hebasto

Contributors

Labels

ci: Refactor: Remove CI_USE_APT_INSTALL #28278

Reviews