clarifying when the .cookie file is generated
doc: clarify cookie generation in JSON-RPC-interface.md #28283
pull iamcarlos94 wants to merge 1 commits into bitcoin:master from iamcarlos94:iamcarlos94-patch-1 changing 1 files +1 −1-
iamcarlos94 commented at 12:48 PM on August 17, 2023: contributor
-
bdb2e8d4ae
Update JSON-RPC-interface.md
clarifying when the .cookie file is generated
-
DrahtBot commented at 12:48 PM on August 17, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko, achow101 Concept ACK jonatack, ErikDeSmedt If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
maflcko commented at 12:55 PM on August 17, 2023: member
lgtm, but missing the
doc:prefix in the Github title? - fanquake renamed this:
Update JSON-RPC-interface.md
doc: clarify cookie generation in JSON-RPC-interface.md
on Aug 17, 2023 - DrahtBot added the label Docs on Aug 17, 2023
-
in doc/JSON-RPC-interface.md:131 in bdb2e8d4ae
127 | @@ -128,7 +128,7 @@ RPC interface will be abused. 128 | Instead, expose it only on the host system's localhost, for example: 129 | `-p 127.0.0.1:8332:8332` 130 | 131 | -- **Secure authentication:** By default, Bitcoin Core generates unique 132 | +- **Secure authentication:** By default, when no `rpcpassword` is specified, Bitcoin Core generates unique
jonatack commented at 4:38 PM on August 17, 2023:- **Secure authentication:** By default, when no `-rpcpassword` configuration option is specified, Bitcoin Core generates unique
Unrelated, is this still planned?
src/httprpc.cpp:251: LogPrintf("Config options rpcuser and rpcpassword will soon be deprecated. Locally-run instances may remove rpcuser to use cookie-based auth, or may be replaced with rpcauth. Please see share/rpcauth for rpcauth auth generation.\n");jonatack commented at 4:39 PM on August 17, 2023: memberConcept ACK
Edit: can optionally rebase to current master for the CI to be green.
DrahtBot added the label CI failed on Aug 17, 2023DrahtBot removed the label CI failed on Aug 18, 2023ErikDeSmedt commented at 11:44 AM on August 21, 2023: noneACK
DrahtBot added the label CI failed on Sep 4, 2023DrahtBot removed the label CI failed on Sep 5, 2023DrahtBot added the label CI failed on Sep 28, 2023DrahtBot removed the label CI failed on Sep 28, 2023maflcko commented at 9:22 AM on September 28, 2023: memberlgtm ACK bdb2e8d4aef927efd4e74d31b5d4dffe73470d1f
DrahtBot requested review from jonatack on Oct 20, 2023DrahtBot added the label CI failed on Oct 25, 2023achow101 commented at 6:37 PM on October 26, 2023: memberACK bdb2e8d4aef927efd4e74d31b5d4dffe73470d1f
achow101 merged this on Oct 26, 2023achow101 closed this on Oct 26, 2023bitcoin locked this on Oct 25, 2024
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:13 UTC
More mirrored repositories can be found on mirror.b10c.me