Remove some CI stuff no longer needed.
ci: Remove /ro_base bind mount, Remove LC_ALL=C from s390x task #28353
pull maflcko wants to merge 3 commits into bitcoin:master from maflcko:2308-ci-cleanup- changing 3 files +7 −8-
maflcko commented at 8:53 PM on August 27, 2023: member
-
doc: Remove sudo from command that is already run as root fa0df9d4c4
-
fa33354dcb
ci: Remove /ro_base bind mount
Just set the bind mount to BASE_READ_ONLY_DIR, which allows to drop one line of code and makes the code easier to understand.
-
ci: Remove unused TEST_RUNNER_ENV="LC_ALL=C" from s390x task fa70cbd969
-
DrahtBot commented at 8:53 PM on August 27, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK fanquake If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #27850 (test: Add unit & functional test coverage for blockstore by pinheadmz)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot renamed this:
ci: Remove /ro_base bind mount, Remove LC_ALL=C from s390x task
ci: Remove /ro_base bind mount, Remove LC_ALL=C from s390x task
on Aug 27, 2023 - DrahtBot added the label Tests on Aug 27, 2023
- DrahtBot added the label CI failed on Aug 27, 2023
- DrahtBot removed the label CI failed on Aug 28, 2023
- fanquake approved
-
fanquake commented at 3:21 PM on August 30, 2023: member
ACK fa70cbd9693b0ccc56114647f0817c96b2f223ee - did not test the s390x job.
- fanquake merged this on Aug 30, 2023
- fanquake closed this on Aug 30, 2023
- maflcko deleted the branch on Aug 30, 2023
- Frank-GER referenced this in commit 32408dcf00 on Sep 8, 2023
- bitcoin locked this on Aug 29, 2024
