doc: Add example of mixing private and public keys in descriptors #28373

1. 
   naiyoma commented at 8:03 PM on August 30, 2023: contributor

   closes: #27414

2. 
   DrahtBot commented at 8:03 PM on August 30, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	achow101, alfonsoromanz
   Stale ACK	BrandonOdiwuor

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   No conflicts as of last run.

3. DrahtBot added the label Docs on Aug 30, 2023
4. naiyoma force-pushed on Aug 30, 2023
5. 
   BrandonOdiwuor commented at 9:03 AM on September 1, 2023: contributor

   ACK #9274ffd

6. DrahtBot added the label CI failed on Sep 3, 2023
7. DrahtBot removed the label CI failed on Sep 5, 2023
8. in doc/descriptors.md:253 in 9274ffdb94 outdated

    249 | +
    250 | +For example, after importing the following 2-of-3 multisig descriptor
    251 | +into a wallet, one could use `signrawtransactionwithwallet`
    252 | +to sign a transaction with the first key:
    253 | +```
    254 | +sh(multi(2,xprv9s21Z.../84'/0'/0'/0/0,0280007cb...,033af7e98...))#lx65wk3z
   

   ---

   ---

   

   Randy808 commented at 12:59 PM on September 11, 2023:

   nit: xprv9s21Z... could be changed to xprv... and the following pubkey values could be changed to xpub1..., xpub2..., etc. since the exact values are unimportant here. The checksum can be omitted as well

   ---

   

   naiyoma commented at 10:44 AM on September 20, 2023:

   I agree with the suggestion, is this sufficient? sh(multi(2,xprv.../84'/0'/0'/0/0,xpub1...,xpub2...))

   ---

   

   achow101 commented at 3:38 PM on September 26, 2023:

   I agree with the suggestion, is this sufficient? sh(multi(2,xprv.../84'/0'/0'/0/0,xpub1...,xpub2...))

   Yes

   ---

   

   naiyoma commented at 9:18 AM on November 10, 2023:

   I did make the changes suggested above

9. naiyoma force-pushed on Sep 29, 2023
10. DrahtBot added the label CI failed on Sep 29, 2023
11. maflcko requested review from BrandonOdiwuor on Nov 13, 2023
12. DrahtBot removed the label CI failed on Nov 13, 2023
13. BrandonOdiwuor approved
14. 
    BrandonOdiwuor commented at 12:58 AM on November 17, 2023: contributor

    Re ACK d3f24f5bd0a84bdd893a351e7987a388a84324f3

    Confirmed change since last review is the descriptor sh(multi(2,xprv.../84'/0'/0'/0/0,xpub1...,xpub2...))

15. fanquake assigned achow101 on Nov 17, 2023
16. alfonsoromanz approved
17. 
    alfonsoromanz commented at 7:44 PM on January 9, 2024: contributor

    ACK

18. DrahtBot added the label CI failed on Jan 12, 2024
19. doc: Add example of mixing private and public keys in descriptors 24b67fa9f6
20. in doc/descriptors.md:255 in d3f24f5bd0 outdated

     251 | +into a wallet, one could use `signrawtransactionwithwallet`
     252 | +to sign a transaction with the first key:
     253 | +```
     254 | +sh(multi(2,xprv.../84'/0'/0'/0/0,xpub1...,xpub2...))
     255 | +```
     256 | +Note how the first key is an xprv private key with a specific descriptor path,
    

    ---

    ---

    

    achow101 commented at 2:13 PM on March 12, 2024:

    s/descriptor path/derivation path

    Note how the first key is an xprv private key with a specific derivation path,
    

    ---

    

    naiyoma commented at 1:45 PM on March 15, 2024:

    update 24b67fa9f602cdeac0e9736256f77d048f616c48

21. naiyoma force-pushed on Mar 15, 2024
22. DrahtBot removed the label CI failed on Mar 15, 2024
23. hernanmarino approved
24. 
    achow101 commented at 6:04 PM on April 16, 2024: member

    ACK 24b67fa9f602cdeac0e9736256f77d048f616c48

25. DrahtBot requested review from BrandonOdiwuor on Apr 16, 2024
26. DrahtBot requested review from alfonsoromanz on Apr 16, 2024
27. alfonsoromanz approved
28. 
    alfonsoromanz commented at 11:54 AM on April 17, 2024: contributor

    Re ACK 24b67fa9f602cdeac0e9736256f77d048f616c48

29. achow101 merged this on Apr 17, 2024
30. achow101 closed this on Apr 17, 2024

    ---

31. PastaPastaPasta referenced this in commit aa0e7ca936 on Oct 25, 2024
32. PastaPastaPasta referenced this in commit acfdf9e438 on Oct 26, 2024
33. PastaPastaPasta referenced this in commit f211bb9289 on Oct 27, 2024
34. bitcoin locked this on Apr 20, 2025

Contributors

naiyomaDrahtBotBrandonOdiwuorRandy808achow101alfonsoromanzhernanmarino

Review Requested
BrandonOdiwuor