[24.x] depends: xcb-proto 1.15.2 #28410

pull fanquake wants to merge 1 commits into bitcoin:24.x from fanquake:fix_python_312_build changing 1 files +2 −2
  1. fanquake commented at 11:46 am on September 5, 2023: member

    Resolves build failures under Python 3.12, i.e building on rawhide:

    0make[3]: Nothing to be done for 'install-exec-am'.
    1 /usr/bin/mkdir -p '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen'
    2 /usr/bin/install -c -m 644 __init__.py error.py expr.py align.py matcher.py state.py xtypes.py '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen'
    3Traceback (most recent call last):
    4  File "<string>", line 2, in <module>
    5ModuleNotFoundError: No module named 'imp'
    6make[3]: *** [Makefile:271: install-pkgpythonPYTHON] Error 1
    

    imp was removed in 3.12: https://docs.python.org/3/library/imp.html.

    Github-Pull: #28097 Rebased-From: 7cb88c8b46723d306b96953a6a60c90a4ab211e3

    Also being backported for 25.x in #28047.

  2. depends: xcb-proto 1.15.2
    Resolves build failures under Python 3.12, i.e building on rawhide:
    ```bash
    make[3]: Nothing to be done for 'install-exec-am'.
     /usr/bin/mkdir -p '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen'
     /usr/bin/install -c -m 644 __init__.py error.py expr.py align.py matcher.py state.py xtypes.py '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen'
    Traceback (most recent call last):
      File "<string>", line 2, in <module>
    ModuleNotFoundError: No module named 'imp'
    make[3]: *** [Makefile:271: install-pkgpythonPYTHON] Error 1
    ```
    
    `imp` was removed in 3.12: https://docs.python.org/3/library/imp.html.
    
    Github-Pull: #28097
    Rebased-From: 7cb88c8b46723d306b96953a6a60c90a4ab211e3
    66b2b109eb
  3. DrahtBot commented at 11:46 am on September 5, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot renamed this:
    [24.x] depends: xcb-proto 1.15.2
    [24.x] depends: xcb-proto 1.15.2
    on Sep 5, 2023
  5. DrahtBot added the label Backport on Sep 5, 2023
  6. hebasto approved
  7. hebasto commented at 11:51 am on September 5, 2023: member
    ACK 66b2b109ebed522817716f73f9490d62d3d9af04
  8. maflcko commented at 11:57 am on September 5, 2023: member

    Should be fine to merge with red CI, but if you want to fix the “previous releases” task, replacing the docker call with:

    0    podman container stop --all  # Similar to "systemctl restart docker"
    

    should do it.

    See #27886 to fix the ARM task.

  9. DrahtBot added the label CI failed on Sep 5, 2023
  10. fanquake commented at 2:29 pm on September 5, 2023: member

    Should be fine to merge with red CI,

    Going to merge this with red CI. We are going to have to followup with a number of CI related backports to release branches, so will leave any changes for then.

  11. fanquake merged this on Sep 5, 2023
  12. fanquake closed this on Sep 5, 2023

  13. fanquake deleted the branch on Sep 5, 2023
  14. fanquake added this to the milestone 24.2 on Oct 10, 2023
  15. bitcoin locked this on Oct 9, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-21 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me