fuzz: Use afl++ shared-memory fuzzing #28460

pull dergoegge wants to merge 1 commits into bitcoin:master from dergoegge:2023-09-afl++-shmem changing 1 files +8 −6

dergoegge commented at 1:55 PM on September 12, 2023: member

Using shared-memory is faster than reading from stdin, see https://github.com/AFLplusplus/AFLplusplus/blob/7d2122e0596132f9344a5d0896020ebc79cd33db/instrumentation/README.persistent_mode.md
DrahtBot commented at 1:55 PM on September 12, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK MarcoFalke

Concept ACK brunoerg

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Sep 12, 2023
dergoegge commented at 1:57 PM on September 12, 2023: member

Would be nice to have a afl++ compiler CI task for stuff like this but probably not worth it overall.

Type	Reviewers
ACK	MarcoFalke
Concept ACK	brunoerg

in src/test/fuzz/fuzz.cpp:206 in d75919d428 outdated

 206 | -        std::vector<uint8_t> buffer;
 207 | -        if (!read_stdin(buffer)) {
 208 | -            continue;
 209 | -        }
 210 | -        test_one_input(buffer);
 211 | +        test_one_input({buffer, __AFL_FUZZ_TESTCASE_LEN});

maflcko commented at 2:01 PM on September 12, 2023:

From the doc you linked to:

 int len = __AFL_FUZZ_TESTCASE_LEN;  // don't use the macro directly in a
                                        // call!

dergoegge commented at 2:09 PM on September 12, 2023:

Fixed

maflcko approved
maflcko commented at 2:01 PM on September 12, 2023: member

Do you have any number to share on how much difference this makes?

[fuzz] Use afl++ shared-memory fuzzing

Using shared-memory is faster than reading from stdin, see
https://github.com/AFLplusplus/AFLplusplus/blob/7d2122e0596132f9344a5d0896020ebc79cd33db/instrumentation/README.persistent_mode.md

97e2e1d641

dergoegge force-pushed on Sep 12, 2023
DrahtBot added the label CI failed on Sep 12, 2023
maflcko commented at 2:10 PM on September 12, 2023: member

review ACK 97e2e1d641016cd7b74848b9560e3771f092c1ea

But it would be good to have number to compare before and after
dergoegge commented at 2:13 PM on September 12, 2023: member

Do you have any number to share on how much difference this makes?

2x according to the docs but that should be subject to the type of disk being used.

I'm seeing a 1.2-1.3x (nvme ssd) running the miniscript_string target.
brunoerg commented at 2:56 PM on September 12, 2023: contributor

Concept ACK
DrahtBot removed the label CI failed on Sep 12, 2023
fanquake merged this on Sep 14, 2023
fanquake closed this on Sep 14, 2023
Frank-GER referenced this in commit 2c9b066e9a on Sep 19, 2023
bitcoin locked this on Sep 13, 2024

Contributors

Labels

fuzz: Use afl++ shared-memory fuzzing #28460

Reviews