Some minor fixups to addr fuzzing
fuzz: Rework addr fuzzing #28470
pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2309-fuzz-addr- changing 1 files +11 −13-
maflcko commented at 2:15 PM on September 13, 2023: member
-
fa5b6d29ee
fuzz: Drop unused params from serialize helpers
With the ser-type and ser-version going away, it seems unlikely that there is need for them in the future, so just remove them.
-
fad52baf1e
fuzz: Rework addr fuzzing
* Replace ConsumeDeserializationParams with V1, because V2 is unconditionally checked as well. * Also fuzz CAddress::Format::Disk in the address_deserialize fuzz target.
-
DrahtBot commented at 2:15 PM on September 13, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK dergoegge If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #28451 (Remove unused SER_DISK, SER_NETWORK, SER_GETHASH by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot renamed this:
fuzz: Rework addr fuzzing
fuzz: Rework addr fuzzing
on Sep 13, 2023 - DrahtBot added the label Tests on Sep 13, 2023
- fanquake requested review from dergoegge on Sep 13, 2023
- dergoegge approved
-
dergoegge commented at 10:53 AM on September 20, 2023: member
utACK fad52baf1e9bf9d55a300922e73d3bc3169a8843
- maflcko added this to the milestone 26.0 on Sep 20, 2023
- fanquake merged this on Sep 20, 2023
- fanquake closed this on Sep 20, 2023
- maflcko deleted the branch on Sep 20, 2023
- Frank-GER referenced this in commit e8f12c2f73 on Sep 25, 2023
- sidhujag referenced this in commit b8881f3596 on Sep 26, 2023
- bitcoin locked this on Sep 19, 2024