doc: Be vague instead of wrong about MALLOC_ARENA_MAX #28512

pull real-or-random wants to merge 1 commits into bitcoin:master from real-or-random:patch-1 changing 1 files +1 −1
  1. real-or-random commented at 5:12 PM on September 20, 2023: contributor

    Before this commit, we claim that glibc's malloc implementation uses 2 arenas by default. But that's true only on 32-bit systems, and even there, it uses up to 2 arenas.

    This commit fixes the wrong statement. The new statement is intentionally vague to reduce our maintenance burden.

    For details, see: https://www.gnu.org/software/libc/manual/html_node/Memory-Allocation-Tunables.html#index-glibc_002emalloc_002earena_005fmax

    Noticed in: #27642 (comment)

  2. doc: Be vague instead of wrong about MALLOC_ARENA_MAX
    Before this commit, we claim that glibc's malloc implementation uses 2
    arenas by default. But that's true only on 32-bit systems, and even
    there, it uses *up* to 2 arenas.
    
    This commit fixes the wrong statement. The new statement is
    intentionally vague to reduce our maintenance burden.
    
    For details, see:
    https://www.gnu.org/software/libc/manual/html_node/Memory-Allocation-Tunables.html#index-glibc_002emalloc_002earena_005fmax
    
    Noticed in:
    https://github.com/bitcoin/bitcoin/pull/27642#issuecomment-1728103427
    12f7257b8f
  3. DrahtBot commented at 5:12 PM on September 20, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Docs on Sep 20, 2023
  5. kevkevinpal commented at 10:07 PM on September 20, 2023: contributor

    lgtm 12f7257

  6. fanquake approved
  7. fanquake commented at 5:54 PM on September 24, 2023: member

    ACK 12f7257b8f6ba0de1fb05b598e916c8b14bcab8c

  8. fanquake merged this on Sep 24, 2023
  9. fanquake closed this on Sep 24, 2023

  10. Frank-GER referenced this in commit f953458e7e on Sep 25, 2023
  11. sidhujag referenced this in commit 18f433beae on Sep 26, 2023
  12. bitcoin locked this on Sep 23, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me