lint: Include test_utxo_snapshots in lint_shell, fix linter errors #28628

1. 
   fjahr commented at 9:38 am on October 10, 2023: contributor

   jamesob excluded test_utxo_snapshots.sh from the shell linter with this explanation: “Add the script to the shellcheck exception list since the quoted variables rule needs to be violated in order to get bitcoind to pick up on $EARLY_IBD_FLAGS.” However, macrofake pointed out that single lines can be excluded from linting.

   This fixes one fixable rule violation, excludes the rest of the offending lines from the linter and then removes the exclusion of the test_utxo_snapshots.sh file. Also adds documentation.

2. 
   DrahtBot commented at 9:38 am on October 10, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	Empact, maflcko, pablomartin4btc

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   No conflicts as of last run.

3. DrahtBot added the label Tests on Oct 10, 2023
4. 
   maflcko commented at 9:58 am on October 10, 2023: member

   lgtm ACK 6f5193efa03cb19e74aea70dcb0dd881ceac5447
5. in contrib/devtools/test_utxo_snapshots.sh:16 in 6f5193efa0 outdated

   10@@ -11,13 +11,16 @@
   11 # loaded. We see the background validation chainstate removed after validation
   12 # completes.
   13 #
   14+# The shellcheck rule SC2086 (quoted variables) disablements are necessary
   15+# since this rule needs to be violated in order to get bitcoind to pick up on
   16+# $CHAIN_HACK_FLAGS for the script to work.
   

   ---

   ---

   

   jamesob commented at 5:00 pm on October 10, 2023:

   CHAIN_HACK_FLAGS is outdated; should be EARLY_IBD_FLAGS

   ---

   

   fjahr commented at 5:52 pm on October 10, 2023:

   fixed
6. fjahr force-pushed on Oct 10, 2023
7. 
   pablomartin4btc commented at 3:01 am on October 13, 2023: member

   ACK 3804fc8

   Should the PR description also be updated with EARLY_IBD_FLAGS?

8. DrahtBot requested review from maflcko on Oct 13, 2023
9. DrahtBot added the label Needs rebase on Oct 13, 2023
10. lint: Include test_utxo_snapshots in lint_shell 348e79f7c6
11. fjahr force-pushed on Oct 13, 2023
12. 
    fjahr commented at 12:07 pm on October 13, 2023: contributor

    Rebased

    Should the PR description also be updated with EARLY_IBD_FLAGS?

    Already fixed by @fanquake

13. DrahtBot removed the label Needs rebase on Oct 13, 2023
14. 
    Empact commented at 8:32 pm on October 13, 2023: contributor

    ACK 348e79f7c6030c9bcbec6bd25e246a779081152a
15. DrahtBot requested review from pablomartin4btc on Oct 13, 2023
16. DrahtBot added the label CI failed on Oct 14, 2023
17. DrahtBot removed the label CI failed on Oct 16, 2023
18. 
    maflcko commented at 4:21 pm on October 16, 2023: member

    lgtm ACK 348e79f7c6030c9bcbec6bd25e246a779081152a
19. DrahtBot removed review request from maflcko on Oct 16, 2023
20. DrahtBot removed review request from pablomartin4btc on Oct 16, 2023
21. DrahtBot requested review from pablomartin4btc on Oct 16, 2023
22. pablomartin4btc approved
23. 
    pablomartin4btc commented at 5:50 pm on October 16, 2023: member

    tACK 348e79f7c6030c9bcbec6bd25e246a779081152a
24. fanquake merged this on Oct 17, 2023
25. fanquake closed this on Oct 17, 2023

    ---

26. Frank-GER referenced this in commit 62d7adce62 on Oct 21, 2023
27. bitcoin locked this on Oct 16, 2024

Contributors
fjahr DrahtBot maflcko jamesob pablomartin4btc Empact

Labels
Tests