ci: Add missing CI_RETRY_EXE before git clone #28643

pull hebasto wants to merge 3 commits into bitcoin:master from hebasto:231012-retry changing 4 files +9 −10

hebasto commented at 2:12 PM on October 12, 2023: member

This PR is a resurrection of #28623:

This should fix bitcoin/bitcoin/actions/runs/6457002476/job/17527598426#step:7:240:

+ git clone --depth=1 https://github.com/bitcoin-core/qa-assets /Users/runner/work/bitcoin/bitcoin/ci/scratch/qa-assets
Cloning into '/Users/runner/work/bitcoin/bitcoin/ci/scratch/qa-assets'...
error: RPC failed; curl 18 HTTP/2 stream 5 was reset
error: 54975 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output
Error: Process completed with exit code 128.

hebasto added the label Tests on Oct 12, 2023
DrahtBot commented at 2:12 PM on October 12, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
hebasto force-pushed on Oct 12, 2023
DrahtBot added the label CI failed on Oct 12, 2023
in ci/test/00_setup_env.sh:74 in 46f38b234f outdated
```
  70 | @@ -71,3 +71,7 @@ export CI_BASE_PACKAGES=${CI_BASE_PACKAGES:-build-essential libtool autotools-de
  71 |  export GOAL=${GOAL:-install}
  72 |  export DIR_QA_ASSETS=${DIR_QA_ASSETS:-${BASE_SCRATCH_DIR}/qa-assets}
  73 |  export CI_RETRY_EXE=${CI_RETRY_EXE:-"retry --"}
  74 | +if [ "$CI_OS_NAME" == "macos" ]; then
```
fanquake commented at 2:56 PM on October 12, 2023:

This file is currently only generic exports. Can we avoid adding platform specific conditionals?

maflcko commented at 3:03 PM on October 12, 2023:

There is probably no better alternative, because the export is needed globally for macos anyway?

hebasto commented at 3:06 PM on October 12, 2023:

It seems it might be moved into ./ci/test/04_install.sh. What do you think?

maflcko commented at 3:11 PM on October 12, 2023:

If there is only one CI_OS_NAME=macos task, then it can be moved to that file. Otherwise, I think putting it here is fine as well, and also seems better than 04_install, which is also global.

hebasto commented at 3:25 PM on October 12, 2023:

Reworked.
hebasto force-pushed on Oct 12, 2023
DrahtBot removed the label CI failed on Oct 12, 2023
DrahtBot added the label Needs rebase on Oct 13, 2023

Type	Reviewers
ACK	maflcko

Revert "ci: Upgrading pip version in macos environment"

This reverts commit 057750c09d0a8331c33966d2cc2285ef82f08af8.

It is not needed anymore in the GHA CI.
This change will make the code much simpler in the following commit.

1c2132ddd9

ci: Export `IN_GETOPT_BIN` on macOS

This variable is required for the `retry` script.

b705bade44

ci: Add missing CI_RETRY_EXE before git clone 6889a80766
hebasto force-pushed on Oct 13, 2023
hebasto commented at 9:40 AM on October 13, 2023: member

Rebased due to the conflict with #28547.
DrahtBot removed the label Needs rebase on Oct 13, 2023
maflcko commented at 9:11 AM on October 20, 2023: member

lgtm ACK 6889a807661cb570e1464ffdedb9ddb1ec970078
fanquake merged this on Oct 20, 2023
fanquake closed this on Oct 20, 2023
hebasto deleted the branch on Oct 20, 2023
Frank-GER referenced this in commit ce449affdf on Oct 21, 2023
bitcoin locked this on Oct 19, 2024

Contributors

Labels

Linked (view graph)

#28623 ci: Add missing CI_RETRY_EXE before git clone

ci: Add missing CI_RETRY_EXE before git clone #28643

Code Coverage

Reviews