fuzz: Allow multiple --m_dir args #28656

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2310-fuzz-multiple-merge- changing 1 files +8 −7

maflcko commented at 11:22 AM on October 16, 2023: member

This allows to merge the result from several servers (or just several folders) at the same time, instead of having to iterate over them.

This should also allow the fuzz engine (libFuzzer) to optimize the final merge result more, because all fuzz inputs from all folders are available at the same time.
DrahtBot commented at 11:22 AM on October 16, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK dergoegge

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Oct 16, 2023
maflcko requested review from murchandamus on Oct 16, 2023
maflcko requested review from dergoegge on Oct 16, 2023
fuzz: Allow multiple --m_dir args faa5e061c2
maflcko force-pushed on Oct 16, 2023
dergoegge approved
dergoegge commented at 4:22 PM on October 16, 2023: member

tACK faa5e061c2f63b868367015561fd376b6ef6052c
fanquake merged this on Oct 17, 2023
fanquake closed this on Oct 17, 2023
maflcko deleted the branch on Oct 17, 2023
in test/fuzz/test_runner.py:73 in faa5e061c2
```
  68 | @@ -69,7 +69,8 @@ def main():
  69 |      )
  70 |      parser.add_argument(
  71 |          '--m_dir',
  72 | -        help='Merge inputs from this directory into the corpus_dir.',
  73 | +        action="append",
  74 | +        help="Merge inputs from these directories into the corpus_dir.",
```
murchandamus commented at 11:55 AM on October 17, 2023:

It could perhaps be clarified that the --m_dir= parameter can be repeated with multiple directories. My first instinct was to use it as the last parameter and try to provide multiple directories with the help text being “from these directories”. Works great when repeated, though.

maflcko commented at 12:04 PM on October 17, 2023:

Happy to review a doc fixup.
murchandamus commented at 11:56 AM on October 17, 2023: contributor

Postmerge tACK with nit faa5e061c2f63b868367015561fd376b6ef6052c
Frank-GER referenced this in commit 6c4be673e2 on Oct 21, 2023
bitcoin locked this on Oct 16, 2024

Type	Reviewers
ACK	dergoegge

Contributors

Labels

fuzz: Allow multiple --m_dir args #28656

Code Coverage

Reviews