refactor: Remove CBlockFileInfo::SetNull #28691

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2310-LessSetNull- changing 3 files +9 −24

maflcko commented at 11:29 AM on October 20, 2023: member

Seems better to use C++11 member initializers and then let the compiler figure out how to construct objects of this class.
DrahtBot commented at 11:29 AM on October 20, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK stickies-v, pablomartin4btc, theStack

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Refactoring on Oct 20, 2023

Type	Reviewers
ACK	stickies-v, pablomartin4btc, theStack

in src/node/blockstorage.cpp:257 in fad1b04ddc outdated

 253 | @@ -254,7 +254,7 @@ void BlockManager::PruneOneBlockFile(const int fileNumber)
 254 |          }
 255 |      }
 256 |  
 257 | -    m_blockfile_info[fileNumber].SetNull();
 258 | +    m_blockfile_info[fileNumber] = CBlockFileInfo{};

stickies-v commented at 1:17 PM on October 20, 2023:

nit: while touching

    m_blockfile_info.at(fileNumber) = CBlockFileInfo{};

in src/chain.h:64 in fad1b04ddc outdated

  74 | -
  75 | -    CBlockFileInfo()
  76 | -    {
  77 | -        SetNull();
  78 | -    }
  79 | +    CBlockFileInfo(){};

stickies-v commented at 1:17 PM on October 20, 2023:

nit

    CBlockFileInfo(){}

stickies-v approved
stickies-v commented at 1:24 PM on October 20, 2023: contributor

ACK fad1b04ddc4e0ca03929f6d47a6510bd699e605c - nice cleanup!
DrahtBot added the label CI failed on Oct 20, 2023
refactor: Remove CBlockFileInfo::SetNull fac36b94ef
maflcko force-pushed on Oct 20, 2023
fanquake requested review from stickies-v on Oct 20, 2023
stickies-v approved
stickies-v commented at 3:23 PM on October 20, 2023: contributor

ACK fac36b94ef32567c0f10b605a3a441d11559e56e
pablomartin4btc approved
pablomartin4btc commented at 7:12 PM on October 20, 2023: member

ACK fac36b94ef32567c0f10b605a3a441d11559e56e
theStack approved
theStack commented at 9:18 PM on October 21, 2023: contributor

LGTM ACK fac36b94ef32567c0f10b605a3a441d11559e56e
fanquake merged this on Oct 23, 2023
fanquake closed this on Oct 23, 2023
maflcko deleted the branch on Oct 23, 2023
Frank-GER referenced this in commit df555a3657 on Nov 28, 2023
bitcoin locked this on Oct 22, 2024

Contributors

Labels

Refactoring CI failed

refactor: Remove CBlockFileInfo::SetNull #28691

Code Coverage

Reviews