ci: Add missing --external to podman image prune #28708

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2310-ci-prune- changing 1 files +4 −1
  1. maflcko commented at 10:07 AM on October 23, 2023: member

    This should fix the out-of-space issues seen in CI. For example:

    https://cirrus-ci.com/task/6208410429947904?logs=ci#L8613

    Error: committing container for step {Env:[FILE_ENV=./ci/test/00_setup_env_native_msan.sh PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin] Command:run Args:[bash -c cd /ci_container_base/ && set -o errexit && source ./ci/test/00_setup_env.sh && ./ci/test/01_base_install.sh] Flags:[] Attrs:map[json:true] Message:RUN bash -c cd /ci_container_base/ && set -o errexit && source ./ci/test/00_setup_env.sh && ./ci/test/01_base_install.sh Original:RUN ["bash", "-c", "cd /ci_container_base/ && set -o errexit && source ./ci/test/00_setup_env.sh && ./ci/test/01_base_install.sh"]}: copying layers and metadata for container "8d882455cc157be6a85d9779b45cacf4dd92a37cfb16fad38213f758a830827d": writing blob: adding layer with blob "sha256:371f657e226fef20f4af6fb88a288dd6248c82c2088daca2d53aaacb51b4303a": processing tar file(write /usr/lib/x86_64-linux-gnu/perl/5.34.0/auto/Unicode/Collate/Collate.so: no space left on device): exit status 1
    
  2. DrahtBot commented at 10:08 AM on October 23, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK stickies-v

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Tests on Oct 23, 2023
  4. fanquake requested review from stickies-v on Oct 23, 2023
  5. stickies-v approved
  6. stickies-v commented at 11:26 AM on October 23, 2023: contributor

    utACK fa13f0a5c5d4b9792abf6286c9a8a8f7d0fe80b3

    nit: would prefer organizing the comments a bit differently

    <details> <summary>git diff on fa13f0a5c5d4b9792abf6286c9a8a8f7d0fe80b3</summary>

    diff --git a/ci/test/02_run_container.sh b/ci/test/02_run_container.sh
    index 4b9cddaa38..26fd6a3f3b 100755
    --- a/ci/test/02_run_container.sh
    +++ b/ci/test/02_run_container.sh
    @@ -35,13 +35,12 @@ if [ -z "$DANGER_RUN_CI_ON_HOST" ]; then
     
         # Still prune everything in case the filtered pruning doesn't work, or if labels were not set
         # on a previous run. Belt and suspenders approach, should be fine to remove in the future.
    -    # Prune external containers (build containers) when using podman.
    -    # (--external should be set below in the --filter command as well, when
    -    # using podman-docker).
    +    # Prune images used by --external containers (e.g. build containers) when using podman.
         echo "Prune all dangling images"
         podman image prune --force --external
       fi
       echo "Prune all dangling $CI_IMAGE_LABEL images"
    +  # When using podman-docker, add `--external`
       docker image prune --force --filter "label=$CI_IMAGE_LABEL"
     
       # shellcheck disable=SC2086
    
    

    </details>

  7. ci: Add missing --external to podman image prune fa65887377
  8. maflcko force-pushed on Oct 23, 2023
  9. stickies-v approved
  10. stickies-v commented at 12:47 PM on October 23, 2023: contributor

    utACK fa6588737714cf26571657fc216552a4291376da

  11. DrahtBot added the label CI failed on Oct 23, 2023
  12. maflcko commented at 2:12 PM on October 23, 2023: member

    Red CI can be ignored for now

  13. fanquake merged this on Oct 23, 2023
  14. fanquake closed this on Oct 23, 2023

  15. maflcko deleted the branch on Oct 23, 2023
  16. Frank-GER referenced this in commit da238afb0c on Nov 28, 2023
  17. bitcoin locked this on Oct 22, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 06:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me