This PR makes it possible to build the qt package with macOS 14 SDK (Xcode 15.0).
For more details, please refer to #28622.
build: Bump `native_clang` up to 17.0.2 #28732
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:231025-clang changing 1 files +7 −6-
hebasto commented at 7:20 PM on October 25, 2023: member
-
build: Bump `native_clang` up to 17.0.2 b3c8caf51f
-
DrahtBot commented at 7:20 PM on October 25, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers Concept NACK fanquake If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Build system on Oct 25, 2023
- maflcko added the label DrahtBot Guix build requested on Oct 25, 2023
-
fanquake commented at 7:30 PM on October 25, 2023: member
I don't understand how bumping Clang would fix building with a newer SDK? How is this related?
Concept NACK in any case, at least until we have LLVM 17 in Guix.
-
maflcko commented at 7:36 PM on October 25, 2023: member
Yes, would be good to keep guix in sync. Otherwise the CI will be less useful. See also #28337 and #28580 (comment)
-
DrahtBot commented at 1:15 AM on October 26, 2023: contributor
<!--9cd9c72976c961c55c7acef8f6ba82cd-->
Guix builds (on x86_64)
- DrahtBot removed the label DrahtBot Guix build requested on Oct 26, 2023
-
fanquake commented at 12:31 PM on October 26, 2023: member
Also, if Clang 17 is required, to compile with the Xcode 15 SDK, wouldn't that make it impossible to compile on macOS using Apple Clang, given the most recent version is only based on LLVM 16?
-
hebasto commented at 12:39 PM on October 26, 2023: member
Also, if Clang 17 is required, to compile with the Xcode 15 SDK, wouldn't that make it impossible to compile on macOS using Apple Clang, given the most recent version is only based on LLVM 16?
From my experience, Clang 16 causes the same errors as the current Clang 15.0.6 does.
-
fanquake commented at 12:46 PM on October 26, 2023: member
Sure, but I can currently use an Apple Clang 15.0.0 (based on LLVM 16), with the Xcode 15 SDK, and everything works ok. I still don't understand what the actual problem is, what has supposedly changed in Clang 17 that fixes it, or how Apple would have managed to change the SDK in such a way that it only works with the most recently released version of Clang.
-
fanquake commented at 1:39 PM on October 31, 2023: member
Can you explain this change? Using a newer Xcode is one of the last the blockers for C++20.
- fanquake marked this as a draft on Oct 31, 2023
-
fanquake commented at 1:58 PM on October 31, 2023: member
Discussed further offline. Moving this to draft for now. As mentioned, bumping Clang isn't required to use C++20, because bitcoind and other utils can already be compiled using C++20, against the newer SDK, so the assumption is that this is something that will need to be patched in Qt?
-
- hebasto closed this on Nov 2, 2023
- fanquake referenced this in commit 160d23677a on Dec 1, 2023
- PastaPastaPasta referenced this in commit 51a8c92abc on Oct 24, 2024
- PastaPastaPasta referenced this in commit fb33ef6771 on Oct 24, 2024
- PastaPastaPasta referenced this in commit a77593e790 on Oct 24, 2024
- PastaPastaPasta referenced this in commit 733a036219 on Oct 24, 2024
- PastaPastaPasta referenced this in commit f670118cce on Oct 24, 2024
- bitcoin locked this on Nov 1, 2024
