[25.x] Backports #28768

1. 
   fanquake commented at 1:25 pm on November 1, 2023: member

   Collecting backports for the 25.x branch. Currently:

   • https://github.com/bitcoin-core/gui/pull/774
   • https://github.com/bitcoin/bitcoin/pull/29003
2. 
   DrahtBot commented at 1:25 pm on November 1, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	stickies-v

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Backport on Nov 1, 2023
4. fanquake added this to the milestone 25.2 on Nov 1, 2023
5. DrahtBot added the label CI failed on Nov 1, 2023
6. fanquake force-pushed on Nov 22, 2023
7. fanquake force-pushed on Dec 6, 2023
8. doc: add historical release notes for 25.1 c21024fd86
9. gui: fix crash on selecting "Mask values" in transaction view

   This commits fixes a crash bug that can be caused with the following steps:
   - change to the "Transactions" view
   - right-click on an arbitrary transaction -> "Show transaction details"
   - close the transaction detail window again
   - select "Settings" -> "Mask values"
   
   The problem is that the list of opened dialogs, tracked in the member
   variable `m_opened_dialogs`, is only ever appended with newly opened
   transaction detail dialog pointers, but never removed. This leads to
   dangling pointers in the list, and if the "Mask values" menu item is
   selected, a crash is caused in the course of trying to close the opened
   transaction detail dialogs (see `closeOpenedDialogs()` method). Fix this
   by removing the pointer from the list if the corresponding widget is
   destroyed.
   
   Github-Pull: https://github.com/bitcoin-core/gui/pull/774
   Rebased-From: e26e665f9f64a962dd56053be817cc953e714847

   b86285df1f
10. fanquake force-pushed on Dec 11, 2023
11. fanquake marked this as ready for review on Jan 11, 2024
12. fanquake requested review from stickies-v on Jan 12, 2024
13. rpc: fix getrawtransaction segfault

    The crash would happen when querying a mempool transaction with verbosity=2, while pruning.
    
    Github-Pull: #29003
    Rebased-From: 494a926d05df44b60b3bc1145ad2a64acf96f61b

    041228d293
14. test: add regression test for the getrawtransaction segfault

    This fails on master without the previous commit.
    
    Github-Pull: #29003
    Rebased-From: 9075a446461ccbc446d21af778aac50b604f39b3

    31e1e035be
15. fanquake force-pushed on Jan 15, 2024
16. in doc/release-notes.md:53 in 115e31b8e9 outdated

    87-
    88-- #27777 ci: Prune dangling images on RESTART_CI_DOCKER_BEFORE_RUN
    89-- #27834 ci: Nuke Android APK task, Use credits for tsan
    90-- #27844 ci: Use podman stop over podman kill
    91-- #27886 ci: Switch to amd64 container in "ARM" task
    92+- #29176 wallet: Fix use-after-free in WalletBatch::EraseRecords
    

    ---

    ---

    

    stickies-v commented at 7:46 pm on January 15, 2024:

    I don’t think this is backported?

    ---

    

    fanquake commented at 9:29 am on January 16, 2024:

    Dropped.
17. 
    stickies-v commented at 7:47 pm on January 15, 2024: contributor

    LGTM 115e31b8e902c02ad4b342843c4811b5e74415d0 modulo small release notes issue. Also, PR description needs to be updated to remove the reference to #28919.
18. 
    jonatack commented at 3:31 am on January 16, 2024: contributor

    #29200 would be relevant.
19. doc: update release notes for 25.x 53bbda5114
20. fanquake force-pushed on Jan 16, 2024
21. 
    fanquake commented at 9:31 am on January 16, 2024: member

    Also, PR description needs to be updated to remove the reference to #28919.

    Updated.

    #29200 would be relevant.

    There’ll be another 25.x backports PR, so it could be included there.

22. stickies-v approved
23. 
    stickies-v commented at 9:52 am on January 16, 2024: contributor

    ACK 53bbda51141e48730b95913c6ae8e1ea50578fbb
24. fanquake merged this on Jan 16, 2024
25. fanquake closed this on Jan 16, 2024

    ---

26. fanquake deleted the branch on Jan 16, 2024

Contributors
fanquake DrahtBot stickies-v jonatack

Labels
Backport CI failed

Milestone
25.2