fuzz: Avoid utxo_total_supply timeout (take 2) #28789

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2311-fuzz-timeout- changing 1 files +3 −3
  1. maflcko commented at 8:30 PM on November 3, 2023: member

    Looks like this still may take a long time to run large fuzz inputs. Thus, reduce it further, but still allow it to catch the regression, if re-introduced:

    diff --git a/src/consensus/tx_check.cpp b/src/consensus/tx_check.cpp
    index f949655909..4bdd15c5ee 100644
    --- a/src/consensus/tx_check.cpp
    +++ b/src/consensus/tx_check.cpp
    @@ -40,7 +40,7 @@ bool CheckTransaction(const CTransaction& tx, TxValidationState& state)
         std::set<COutPoint> vInOutPoints;
         for (const auto& txin : tx.vin) {
             if (!vInOutPoints.insert(txin.prevout).second)
    -            return state.Invalid(TxValidationResult::TX_CONSENSUS, "bad-txns-inputs-duplicate");
    +            {}//return state.Invalid(TxValidationResult::TX_CONSENSUS, "bad-txns-inputs-duplicate");
         }
     
         if (tx.IsCoinBase())
    

    This is the second take, see #27780. If in the future it still times out, I think the fuzz test can just be removed.

    Example input:

    JREROy5pcnAgQyw7IC4ODg4ODg4ODg4O0dEODg4ODg4ZDg4ODg4ODg4ODg7RDg4ODg4ODg4O0dEODg4ODg4ODg4ODg7R0Q4ODg4ODg4ODtHRDg4ODtHR0dEODg4O0dEODg7R0Q4ODg4ODg4ODtHRDg4ODg4ODg4ODg4O0dEODg4ODg4ODg7R0Q4ODg7R0Q4O0dEODg4ODg4ODg4ODg7R0Q4ODg4ODtHRDg4ODtHR
    
  2. fuzz: Avoid utxo_total_supply timeout fa7ba92630
  3. DrahtBot commented at 8:30 PM on November 3, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK dergoegge, brunoerg

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Nov 3, 2023
  5. dergoegge approved
  6. dergoegge commented at 10:00 AM on November 6, 2023: member

    ACK fa7ba926300f44b350d04262e569cc607e4991d8

  7. brunoerg approved
  8. brunoerg commented at 11:10 AM on November 7, 2023: contributor

    utACK fa7ba926300f44b350d04262e569cc607e4991d8

  9. fanquake merged this on Nov 7, 2023
  10. fanquake closed this on Nov 7, 2023

  11. maflcko deleted the branch on Nov 7, 2023
  12. bitcoin locked this on Nov 6, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-20 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me