fuzz: Fix nullptr deref in scriptpubkeyman #28968

1. 
   maflcko commented at 3:01 PM on November 29, 2023: member

   This should fix the UB that was found by review (https://github.com/bitcoin/bitcoin/pull/28578#discussion_r1404246109) and by fuzzing (https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=64487)

2. 
   DrahtBot commented at 3:01 PM on November 29, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	dergoegge, brunoerg

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Tests on Nov 29, 2023
4. fuzz: Fix nullptr deref in scriptpubkeyman

   Also, add missing includes to scriptpubkeyman.
   
   Also, export dependecies of the BasicTestingSetup from setup_common.h,
   to avoid having to include them when setup_common.h is already included.

   faecde9102
5. maflcko force-pushed on Nov 29, 2023
6. dergoegge approved
7. 
   dergoegge commented at 3:07 PM on November 29, 2023: member

   utACK faecde9102f2e4199df3ec760f9378b114a87531

8. brunoerg approved
9. 
   brunoerg commented at 3:21 PM on November 29, 2023: contributor

   crACK faecde9102f2e4199df3ec760f9378b114a87531

   nice

10. maflcko added this to the milestone 27.0 on Nov 29, 2023
11. fanquake merged this on Nov 29, 2023
12. fanquake closed this on Nov 29, 2023

    ---

13. maflcko deleted the branch on Nov 29, 2023
14. bitcoin locked this on Nov 28, 2024

Milestone
27.0