fuzz: txorphan check wtxids using GenTxid::Wtxid not GenTxid::Txid #28997

1. 
   instagibbs commented at 7:46 pm on December 4, 2023: member

   Fixes the bugs in the fuzz test with no more changes as an alternative to https://github.com/bitcoin/bitcoin/pull/28658
2. fuzz: txorphan check wtxids using GenTxid::Wtxid not GenTxid::Txid 38816ff64e
3. instagibbs marked this as ready for review on Dec 4, 2023
4. 
   DrahtBot commented at 7:46 pm on December 4, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	naumenkogs, dergoegge

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. DrahtBot added the label Tests on Dec 4, 2023
6. fanquake requested review from dergoegge on Dec 4, 2023
7. 
   naumenkogs commented at 9:07 am on December 5, 2023: member

   ACK 38816ff64ed90a55e4879e9b440cdc876302f750
8. dergoegge approved
9. 
   dergoegge commented at 10:49 am on December 5, 2023: member

   ACK 38816ff64ed90a55e4879e9b440cdc876302f750
10. fanquake merged this on Dec 5, 2023
11. fanquake closed this on Dec 5, 2023

    ---

12. 
    maflcko commented at 11:56 am on December 5, 2023: member

    Fixes the bugs in the fuzz test with no more changes as an alternative to #28658

    Can you explain the “bugs”? The wtxid is equal to the txid for transactions that have not witness data, and all transactions in this test have no witness data.

    Seems fine to fix the style and make this refactor, but I don’t see any bugs.

    Also, if there was a bug, the test should be fixed to catch it, no?

Contributors
instagibbs DrahtBot naumenkogs dergoegge maflcko

Labels
Tests