Fixes the bugs in the fuzz test with no more changes as an alternative to https://github.com/bitcoin/bitcoin/pull/28658
fuzz: txorphan check wtxids using GenTxid::Wtxid not GenTxid::Txid #28997
pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:txorphan_fuzz_whash changing 1 files +5 −5-
instagibbs commented at 7:46 PM on December 4, 2023: member
-
fuzz: txorphan check wtxids using GenTxid::Wtxid not GenTxid::Txid 38816ff64e
- instagibbs marked this as ready for review on Dec 4, 2023
-
DrahtBot commented at 7:46 PM on December 4, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK naumenkogs, dergoegge If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Dec 4, 2023
- fanquake requested review from dergoegge on Dec 4, 2023
-
naumenkogs commented at 9:07 AM on December 5, 2023: member
ACK 38816ff64ed90a55e4879e9b440cdc876302f750
- dergoegge approved
-
dergoegge commented at 10:49 AM on December 5, 2023: member
ACK 38816ff64ed90a55e4879e9b440cdc876302f750
- fanquake merged this on Dec 5, 2023
- fanquake closed this on Dec 5, 2023
-
maflcko commented at 11:56 AM on December 5, 2023: member
Fixes the bugs in the fuzz test with no more changes as an alternative to #28658
Can you explain the "bugs"? The wtxid is equal to the txid for transactions that have not witness data, and all transactions in this test have no witness data.
Seems fine to fix the style and make this refactor, but I don't see any bugs.
Also, if there was a bug, the test should be fixed to catch it, no?
- bitcoin locked this on Dec 5, 2024
Contributors
Labels