[26.x] Backports #29011

pull fanquake wants to merge 18 commits into bitcoin:26.x from fanquake:26_1_backports changing 21 files +601 −319

fanquake commented at 2:16 pm on December 6, 2023: member
Backports for 26.x. Currently:
- #28920
- #28992
- #28994
- #29003
- #29023
- #29080
- #29176
fanquake added this to the milestone 26.1 on Dec 6, 2023
DrahtBot commented at 2:16 pm on December 6, 2023: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers

ACK TheCharlatan, glozow

Stale ACK willcl-ark

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Backport on Dec 6, 2023
DrahtBot added the label CI failed on Dec 6, 2023

Type	Reviewers
ACK	TheCharlatan, glozow
Stale ACK	willcl-ark

doc: add historical release notes for 26.0

Github-Pull: #29023
Rebased-From: 7d4e47d1849ba00c5b45995a96f2c747f1a97c71

8dc2c753ff

doc: Missing additions to 26.0 release notes

Github-Pull: #29023
Rebased-From: ca5937553b4b4dde53995d0b66e30150401023eb

d2c80b6f52

fanquake force-pushed on Dec 8, 2023
fanquake marked this as ready for review on Dec 8, 2023
willcl-ark commented at 10:49 am on December 8, 2023: member

ACK 188e023d2fdab30b4a779a862b2c8b567bb15803

Checked diffs between Rebased-from commit hash and these commits themselves.
DrahtBot removed the label CI failed on Dec 8, 2023
fanquake force-pushed on Dec 12, 2023
fanquake commented at 5:43 pm on December 12, 2023: member

Note that any tidy job failure here is currently related to #28992 (comment) (and should be fixed in future).
DrahtBot added the label CI failed on Dec 12, 2023
fanquake force-pushed on Dec 13, 2023
DrahtBot removed the label CI failed on Dec 13, 2023
fanquake force-pushed on Dec 15, 2023
fanquake force-pushed on Dec 15, 2023
luke-jr commented at 7:03 pm on December 17, 2023: member

7e90b5938f4dbdba58355f55f785c9054055a912 has a typo in the commit message
fanquake force-pushed on Dec 18, 2023
fanquake force-pushed on Jan 4, 2024

ci: Use Ubuntu 24.04 Noble for tsan,tidy,fuzz

Github-Pull: #28992
Rebased-From: fa83b65ef8934b44fbac02da8dbc27fc0bc230e6

69e53d1e47

ci: Use Ubuntu 24.04 Noble for asan

Github-Pull: #28992
Rebased-From: fad2392c5861a88a87cb8a03d2fc9773e178feb8

81e744a9a6

rpc: fix getrawtransaction segfault

The crash would happen when querying a mempool transaction with verbosity=2, while pruning.

Github-Pull: #29003
Rebased-From: 494a926d05df44b60b3bc1145ad2a64acf96f61b

5097bb3389

test: add regression test for the getrawtransaction segfault

This fails on master without the previous commit.

Github-Pull: #29003
Rebased-From: 9075a446461ccbc446d21af778aac50b604f39b3

b15e2e2cec

wallet: skip BnB when SFFO is active

Co-authored-by: furszy <matiasfurszyfer@protonmail.com>

Github-Pull: #28994
Rebased-From: 5cea25ba795d6eb9ccc721d01560783ae576af34

5493ebbe74

wallet: create tx, log resulting coin selection info

Useful for understanding what is going on internally
when the software is running. Debug issues, and provide
more accurate feedback to users.

Github-Pull: #28994
Rebased-From: 0c5755761c3e544547899ad096121585dffa73df

05d0576d3c

test: add coverage for BnB-SFFO restriction

Verify the transaction creation process does not produce
a BnB solution when SFFO is enabled.
This is currently problematic because it could require a
change output. And BnB is specialized on changeless solutions.

Co-authored-by: Andrew Chow <achow101@gmail.com>
Co-authored-by: Murch <murch@murch.one>

Github-Pull: #28994
Rebased-From: 05e5ff194c7722b4ebc2b9309fc0bf47b3cf1df7

903b4623d3

fuzz: disable BnB when SFFO is enabled

Github-Pull: #28994
Rebased-From: 576bee88fd36e207b7288077626947a1fce0fc33

35039ac3cc

refactor: rename FirstKeyTimeChanged to MaybeUpdateBirthTime

In the following-up commit, the wallet birth time will also
be modified by the transactions scanning process. When a tx
older than all descriptor's timestamp is detected.

Github-Pull: #28920
Rebased-From: b4306e3c8db6cbaedc8845c6d21c750b39f682bf

074296dd60

wallet: birth time update during tx scanning

As the user could have imported a descriptor with
a newer timestamp (by blindly setting 'timestamp=now'),
the wallet needs to update the birth time when it detects
a transaction older than the oldest descriptor timestamp.

Github-Pull: #28920
Rebased-From: 75fbf444c1e13c6ba0e79a34871534c845a13849

84f4a6c145

wallet: fix legacy spkm default birth time

To avoid scanning blocks, as assumed by a wallet with no
generated keys or imported scripts, the default value for
the birth time needs to be set to the maximum int64_t value.

Once the first key is generated or the first script is imported,
the legacy SPKM will update the birth time automatically.

Github-Pull: #28920
Rebased-From: 6f497377aa17cb8a590fd7717fa8ededf4249999

0fa47e2569

test: coverage for wallet birth time interaction with -reindex

Verifying the wallet updates the birth time accordingly when it
detects a transaction with a time older than the oldest descriptor
timestamp.
This could happen when the user blindly imports a descriptor with
'timestamp=now'.

Github-Pull: #28920
Rebased-From: 83c66444d0604f0a9ec3bc3f89d4f1a810b7cda0

12834012c2

rpc: getwalletinfo, return wallet 'birthtime'

And add coverage for it

Github-Pull: #28920
Rebased-From: 1ce45baed7dd2da3f1cb85c9c25110e5537451ae

b06b14e68d

ci: Set `HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK` to avoid failures

Homebrew attempts to check for outdated dependents or those with broken
linkage. Such behavior might lead to failures when Homebrew updates them
on old macOS images.

This change prevents such behavior.

Github-Pull: #29080
Rebased-From: 43c3246af774bda284111056268a814477f9b256

40252e184e

wallet: Fix use-after-free in WalletBatch::EraseRecords

Github-Pull: #29176
Rebased-From: faebf1df2afe207f5d2d4f73f50ac66824fe34bb

ccf00b1e6e

doc: update release notes for 26.x 7b79e54474
fanquake force-pushed on Jan 4, 2024
TheCharlatan approved
TheCharlatan commented at 4:24 pm on January 4, 2024: contributor

ACK 7b79e54474b86864c81148c74824bfe4b732412d
DrahtBot requested review from willcl-ark on Jan 4, 2024
DrahtBot added the label CI failed on Jan 4, 2024
glozow commented at 2:20 pm on January 9, 2024: member

ACK 7b79e54474b86864c81148c74824bfe4b732412d, matches mine
jonatack commented at 3:15 pm on January 9, 2024: member

Suggest backporting #29200 that resolves #29197.
glozow commented at 3:40 pm on January 9, 2024: member

I’m planning to merge this now and open another batch of backports
glozow merged this on Jan 9, 2024
glozow closed this on Jan 9, 2024
fanquake deleted the branch on Jan 9, 2024
bitcoin locked this on Jan 8, 2025

Contributors
fanquake DrahtBot willcl-ark luke-jr TheCharlatan glozow jonatack

Review Requested
willcl-ark

Labels
Backport CI failed

Milestone
26.1

[26.x] Backports #29011

Code Coverage

Reviews