fuzz: Improve fuzzing stability for txorphan harness #29031

pull dergoegge wants to merge 1 commits into bitcoin:master from dergoegge:2023-12-fuzz-stability-txorphan changing 5 files +9 −8

dergoegge commented at 1:18 PM on December 8, 2023: member

The txorphan harness has low stability as eviction of orphan txs is entirely random at the moment.

Fix this by passing the rng to LimitOrphans, which can be deterministic in tests.

Also see #29018.
fuzz: Improve fuzzing stability for txorphan harness 15f5a0d0c8
DrahtBot commented at 1:18 PM on December 8, 2023: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK maflcko, brunoerg

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #28970 ([WIP] p2p: opportunistically accept 1-parent-1-child packages by glozow)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
dergoegge marked this as ready for review on Dec 8, 2023
DrahtBot added the label Tests on Dec 8, 2023
brunoerg commented at 1:19 PM on December 8, 2023: contributor

Concept ACK

nice!
maflcko commented at 2:06 PM on December 8, 2023: member

lgtm ACK 15f5a0d0c8ce6b306cdeba6a4777334b848a76aa

Didn't test the stability score.
DrahtBot requested review from brunoerg on Dec 8, 2023
dergoegge commented at 2:13 PM on December 8, 2023: member

Didn't test the stability score.

I'm seeing 87% stability locally, up from 51% reported by oss-fuzz. Not sure why it isn't a 100%, can't see anything else in the orphanage that would be non-deterministic.
brunoerg approved
brunoerg commented at 2:13 PM on December 8, 2023: contributor

utACK 15f5a0d0c8ce6b306cdeba6a4777334b848a76aa
fanquake merged this on Dec 11, 2023
fanquake closed this on Dec 11, 2023
glozow commented at 1:30 PM on December 11, 2023: member

concept ACK 15f5a0d0c8ce6b306cdeba6a4777334b848a76aa
Fabcien referenced this in commit 1e1bd1cbf6 on Jul 19, 2024
roqqit referenced this in commit c5d41a2441 on Aug 1, 2024
bitcoin locked this on Dec 10, 2024