msvc: Define the same QT_... macros as in Autotools builds #29044

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:231209-msvc-qt changing 1 files +6 −0
  1. hebasto commented at 4:18 pm on December 9, 2023: member

    There are no reasons to have such a diversion.

    Also it fixes #28960 (comment).

  2. msvc: Define the same `QT_...` macros as in Autotools builds 1a5dae630d
  3. DrahtBot commented at 4:18 pm on December 9, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK sipsorcery, TheCharlatan

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. hebasto added the label Windows on Dec 9, 2023
  5. hebasto added the label Build system on Dec 9, 2023
  6. sipsorcery commented at 10:29 pm on December 9, 2023: member

    @hebasto what version of QT are you using for Windows builds?

    It’s been a while since I did a QT build and I’m having lots of challenges with 5.15.11 on master.

  7. hebasto commented at 10:40 pm on December 9, 2023: member

    @hebasto what version of QT are you using for Windows builds?

    Qt 5.15.11

    It’s been a while since I did a QT build and I’m having lots of challenges with 5.15.11 on master.

    I’ve just done another Qt 5.15.11 build today with no issues.

  8. sipsorcery commented at 11:34 pm on December 9, 2023: member
    tACK 1a5dae630df1eef9eac51557b2f1c5dba0924953.
  9. TheCharlatan approved
  10. TheCharlatan commented at 10:46 am on December 11, 2023: contributor

    ACK 1a5dae630df1eef9eac51557b2f1c5dba0924953

    Thank you @hebasto, this fixes the build failure of #28960.

  11. fanquake merged this on Dec 11, 2023
  12. fanquake closed this on Dec 11, 2023

  13. hebasto deleted the branch on Dec 11, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me