There are no reasons to have such a diversion.
Also it fixes #28960 (comment).
msvc: Define the same `QT_...` macros as in Autotools builds #29044
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:231209-msvc-qt changing 1 files +6 −0-
hebasto commented at 4:18 PM on December 9, 2023: member
-
msvc: Define the same `QT_...` macros as in Autotools builds 1a5dae630d
-
DrahtBot commented at 4:18 PM on December 9, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK sipsorcery, TheCharlatan If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- hebasto added the label Windows on Dec 9, 2023
- hebasto added the label Build system on Dec 9, 2023
-
sipsorcery commented at 10:29 PM on December 9, 2023: contributor
@hebasto what version of QT are you using for Windows builds?
It's been a while since I did a QT build and I'm having lots of challenges with
5.15.11onmaster. -
-
sipsorcery commented at 11:34 PM on December 9, 2023: contributor
tACK 1a5dae630df1eef9eac51557b2f1c5dba0924953.
- TheCharlatan approved
-
TheCharlatan commented at 10:46 AM on December 11, 2023: contributor
- fanquake merged this on Dec 11, 2023
- fanquake closed this on Dec 11, 2023
- hebasto deleted the branch on Dec 11, 2023
- bitcoin locked this on Dec 10, 2024
Contributors
Labels