Revert “ci: Only run functional tests on windows in master” #29059

1. 
   hebasto commented at 10:14 am on December 12, 2023: member

   This PR reverts commit aba4a5887b44bf7cbee9ea0a8e02bb92c1b4147b from #28567.

   The Windows-specific code received quality and performance improvements recently. So there are no reasons to skip functional tests in PRs anymore.

   In my own repo, I’ve run the GHA Windows job more than 100 times with no failure.

2. Revert "ci: Only run functional tests on windows in master"

   This reverts commit aba4a5887b44bf7cbee9ea0a8e02bb92c1b4147b.

   7b22cd80e0
3. hebasto added the label Windows on Dec 12, 2023
4. hebasto added the label Tests on Dec 12, 2023
5. 
   DrahtBot commented at 10:14 am on December 12, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko, TheCharlatan

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

6. in .github/workflows/ci.yml:286 in 7b22cd80e0

   288-        # not yet been determined.
   289-        # Discussed in https://github.com/bitcoin/bitcoin/pull/28509
   290-        if: github.event_name != 'pull_request'
   291-        run: py -3 test\functional\test_runner.py --jobs $env:NUMBER_OF_PROCESSORS --ci --quiet --tmpdirprefix=$env:RUNNER_TEMP --combinedlogslen=99999999 --timeout-factor=$env:TEST_RUNNER_TIMEOUT_FACTOR --extended
   292+        env:
   293+          TEST_RUNNER_EXTRA: ${{ github.event_name != 'pull_request' && '--extended' || '' }}
   

   ---

   ---

   

   maflcko commented at 10:27 am on December 12, 2023:

   How much longer would it take to also run --extended?

   ---

   

   hebasto commented at 10:38 am on December 12, 2023:

   How much longer would it take to also run --extended?

   Appr. extra 10 minutes.

   The feature_dbcrash.py test takes the longest time.

7. 
   maflcko commented at 11:03 am on December 12, 2023: member

   lgtm ACK 7b22cd80e050b903b5765133b8116f4b17ce0296
8. TheCharlatan approved
9. 
   TheCharlatan commented at 1:07 pm on December 12, 2023: contributor

   ACK 7b22cd80e050b903b5765133b8116f4b17ce0296
10. fanquake merged this on Dec 12, 2023
11. fanquake closed this on Dec 12, 2023

    ---

12. hebasto deleted the branch on Dec 12, 2023
13. 
    fanquake commented at 9:58 am on December 15, 2023: member

    Looks like these are still just randomly failing: #29090 ?
14. 
    hebasto commented at 10:08 am on December 15, 2023: member

    Looks like these are still just randomly failing: #29090 ?

    Perhaps, it depends on the image version? That one was 20231211.1.0.

15. 
    fanquake commented at 10:11 am on December 15, 2023: member

    I don’t think so. The last run on master passed with that image version: https://github.com/bitcoin/bitcoin/actions/runs/7214949583/job/19658167262.
16. bitcoin locked this on Dec 14, 2024

Contributors
hebasto DrahtBot maflcko TheCharlatan fanquake

Labels
Windows Tests