fuzz: set `m_fallback_fee` and `m_fee_mode` in `wallet_fees` target #29076

1. 
   brunoerg commented at 6:50 PM on December 13, 2023: contributor

   m_fallback_fee and m_fee_mode are used in GetMinimumFeeRate but we're not setting any value for them in wallet_fees target. That's the reason fuzzing is never reaching the following code:

   

   This PR fixes it.

2. 
   DrahtBot commented at 6:50 PM on December 13, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko, murchandamus, achow101
   Concept ACK	BrandonOdiwuor

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Tests on Dec 13, 2023
4. 
   maflcko commented at 9:12 PM on December 13, 2023: member

   Could squash this easy change into one commit?

5. fuzz: set `m_fallback_fee`/`m_fee_mode` in `wallet_fees` target e03d6f7ed5
6. brunoerg force-pushed on Dec 13, 2023
7. 
   brunoerg commented at 9:21 PM on December 13, 2023: contributor

   Could squash this easy change into one commit?

   Sure, done!

8. 
   maflcko commented at 8:45 AM on December 14, 2023: member

   GHA fail can be ignored:

   ==> Pouring python@3.11--3.11.6_1.ventura.bottle.tar.gz
   Error: The `brew link` step did not complete successfully
   The formula built, but is not symlinked into /usr/local
   Could not symlink bin/2to3
   Target /usr/local/bin/2to3
   already exists. You may want to remove it:
     rm '/usr/local/bin/2to3'
   
   To force the link and overwrite all conflicting files:
     brew link --overwrite python@3.11
   
   To list all files that would be deleted:
     brew link --overwrite --dry-run python@3.11
   
   Possible conflicting files are:
   /usr/local/bin/2to3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/2to3
   /usr/local/bin/2to3-3.11 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/2to3-3.11
   /usr/local/bin/idle3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/idle3
   /usr/local/bin/idle3.11 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/idle3.11
   /usr/local/bin/pydoc3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/pydoc3
   /usr/local/bin/pydoc3.11 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/pydoc3.11
   /usr/local/bin/python3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3
   /usr/local/bin/python3-config -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3-config
   /usr/local/bin/python3.11 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/python3.11
   /usr/local/bin/python3.11-config -> /Library/Frameworks/Python.framework/Versions/3.11/bin/python3.11-config
   ==> /usr/local/Cellar/python@3.11/3.11.6_1/bin/python3.11 -Im ensurepip
   ==> /usr/local/Cellar/python@3.11/3.11.6_1/bin/python3.11 -Im pip install -v --n
   ==> Caveats
   Python has been installed as
     /usr/local/bin/python3
   
   Unversioned symlinks `python`, `python-config`, `pip` etc. pointing to
   `python3`, `python3-config`, `pip3` etc., respectively, have been installed into
     /usr/local/opt/python@3.11/libexec/bin
   
   You can install Python packages with
     pip3 install <package>
   They will install into the site-package directory
     /usr/local/lib/python3.11/site-packages
   
   tkinter is no longer included with this formula, but it is available separately:
     brew install python-tk@3.11
   
   gdbm (`dbm.gnu`) is no longer included in this formula, but it is available separately:
     brew install python-gdbm@3.11
   `dbm.ndbm` changed database backends in Homebrew Python 3.11.
   If you need to read a database from a previous Homebrew Python created via `dbm.ndbm`,
   you'll need to read your database using the older version of Homebrew Python and convert to another format.
   `dbm` still defaults to `dbm.gnu` when it is installed.
   
   For more information about Homebrew and Python, see: https://docs.brew.sh/Homebrew-and-Python
   ==> Summary
   

9. 
   maflcko commented at 8:45 AM on December 14, 2023: member

   review ACK e03d6f7ed534f423f58236866f8e83beee1871e1

10. 
    BrandonOdiwuor commented at 10:52 AM on December 28, 2023: contributor

    Concept ACK

11. 
    murchandamus commented at 6:15 PM on December 28, 2023: contributor

    ACK e03d6f7ed534f423f58236866f8e83beee1871e1

    Any idea what the CI is upset about?

12. DrahtBot requested review from BrandonOdiwuor on Dec 28, 2023
13. DrahtBot removed review request from BrandonOdiwuor on Dec 28, 2023
14. DrahtBot requested review from BrandonOdiwuor on Dec 28, 2023
15. maflcko added this to the milestone 27.0 on Dec 29, 2023
16. 
    achow101 commented at 4:26 PM on January 2, 2024: member

    ACK e03d6f7ed534f423f58236866f8e83beee1871e1

17. DrahtBot removed review request from BrandonOdiwuor on Jan 2, 2024
18. DrahtBot requested review from BrandonOdiwuor on Jan 2, 2024
19. achow101 merged this on Jan 2, 2024
20. achow101 closed this on Jan 2, 2024

    ---

21. theStack referenced this in commit bf0ee88c8d on Sep 12, 2024
22. bitcoin locked this on Jan 1, 2025

Contributors

brunoergDrahtBotmaflckoBrandonOdiwuormurchandamusachow101

Review Requested
BrandonOdiwuor

Milestone
27.0