contrib: add macho branch protection check #29170

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:add_macho_branch_protection_check changing 2 files +15 −5

fanquake commented at 5:36 pm on January 3, 2024: member

Followup to #28459. Add a sanity check that bti instructions are present in the arm macho binary, similar to our x86_64 check for control flow.

Could do something similar for aarch64 linux in future, and maybe could use https://github.com/lief-project/LIEF/issues/975.
contrib: add macho branch protection check 5335e454c0
DrahtBot commented at 5:36 pm on January 3, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers

ACK TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
fanquake added the label DrahtBot Guix build requested on Jan 3, 2024

Type	Reviewers
ACK	TheCharlatan

DrahtBot commented at 6:17 am on January 4, 2024: contributor

Guix builds (on x86_64)

File	commit 65c05db660b2ca1d0076b0d8573a6760b3228068(master)	commit fa783cc503de28f62a4328c3e960d33bee03ee1d(master and this pull)
SHA256SUMS.part	`d97ad5d47c095d44...`	`8097c4d0202e874a...`
*-aarch64-linux-gnu-debug.tar.gz	`c3db617f3148f66f...`	`d44cb3109a7d6010...`
*-aarch64-linux-gnu.tar.gz	`b2cf69e9adb2ed95...`	`943c1b2b015df3b0...`
*-arm-linux-gnueabihf-debug.tar.gz	`924b3b035081a1df...`	`e3d241e6b101d62f...`
*-arm-linux-gnueabihf.tar.gz	`086a7297ab18d363...`	`57ac128bf25ecfe8...`
*-arm64-apple-darwin-unsigned.tar.gz	`7fb7559d02277a55...`	`039e2ca8fafbb087...`
*-arm64-apple-darwin-unsigned.zip	`4de0cca0c1ad3765...`	`1449351fe08851cb...`
*-arm64-apple-darwin.tar.gz	`ef3406f2e73ac212...`	`ee6deeb0f28cc36e...`
*-powerpc64-linux-gnu-debug.tar.gz	`7d4f91457cf2b2fb...`	`5286923bccec7fd3...`
*-powerpc64-linux-gnu.tar.gz	`001a8faa69f350c8...`	`336b91970cd87cb6...`
*-powerpc64le-linux-gnu-debug.tar.gz	`8cc12ee8e740aa9b...`	`e470f06ca7af7fe6...`
*-powerpc64le-linux-gnu.tar.gz	`b0b5df8e35ce5d72...`	`32ed5350320125fc...`
*-riscv64-linux-gnu-debug.tar.gz	`bf6762a840dc9b6a...`	`479b06a7c48b9554...`
*-riscv64-linux-gnu.tar.gz	`cb09fb0705923f3e...`	`ff0786ab0bb88ff7...`
*-x86_64-apple-darwin-unsigned.tar.gz	`388d2d01d87e50c1...`	`3ff7a2c8804d3886...`
*-x86_64-apple-darwin-unsigned.zip	`6089e05883e95fa2...`	`188b486dd569e3bd...`
*-x86_64-apple-darwin.tar.gz	`dc4a5cb0b8bd0c60...`	`34a11c19374e5406...`
*-x86_64-linux-gnu-debug.tar.gz	`adf8ebf8576ee97d...`	`2356632c38f996cb...`
*-x86_64-linux-gnu.tar.gz	`598868ef1a2e0b40...`	`09cd85473c59bb54...`
*.tar.gz	`9038887954759e98...`	`db23fbeeeca6a47e...`
guix_build.log	`7b7f0eee6671ab54...`	`f0a43b6de88bff70...`
guix_build.log.diff		`d26112876bcf58c0...`

DrahtBot removed the label DrahtBot Guix build requested on Jan 4, 2024
DrahtBot added the label Scripts and tools on Jan 4, 2024
DrahtBot added the label CI failed on Jan 15, 2024
TheCharlatan approved
TheCharlatan commented at 8:44 pm on January 15, 2024: contributor

ACK 5335e454c0889c8a1bb05aa09435883322133974
fanquake merged this on Jan 16, 2024
fanquake closed this on Jan 16, 2024
fanquake deleted the branch on Jan 16, 2024

Contributors
fanquake DrahtBot TheCharlatan

Labels
Scripts and tools CI failed

contrib: add macho branch protection check #29170

Code Coverage

Reviews

Guix builds (on x86_64)