For example, in the native macOS CI job, the LD_LIBRARY_PATH=/Users/runner/work/bitcoin/bitcoin/depends/x86_64-apple-darwin/lib makes no sense.
ci: Do not set inane value for `LD_LIBRARY_PATH` #29196
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240107-ldlibpath changing 1 files +7 −4-
hebasto commented at 12:30 PM on January 7, 2024: member
-
DrahtBot commented at 12:30 PM on January 7, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #28736 (ci: run test_bitcoin with DEBUG_LOG_OUT in RUN_UNIT_TESTS_SEQUENTIAL by vasild)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot added the label Tests on Jan 7, 2024
-
ci: Do not set inane value for `LD_LIBRARY_PATH` df4e35a59f
- hebasto force-pushed on Jan 7, 2024
- DrahtBot added the label CI failed on Jan 7, 2024
- DrahtBot removed the label CI failed on Jan 7, 2024
-
fanquake commented at 10:31 AM on January 8, 2024: member
For example, in the native macOS CI job,
Unless there's a downside to having this set, I don't think it's worth the extra code / shellcheck exceptions. i.e in this example, ld64 will never read this ENV var?
- DrahtBot added the label CI failed on Jan 15, 2024
-
fanquake commented at 2:44 PM on February 26, 2024: member
Any follow up here?
- hebasto closed this on Feb 26, 2024
- bitcoin locked this on Feb 25, 2025
