test: wallet migration, add coverage for tx extra data #29204

pull furszy wants to merge 1 commits into bitcoin:master from furszy:2023_test_wallet_txs_comments_migration changing 1 files +35 −0

furszy commented at 3:05 PM on January 8, 2024: member

Quick follow-up to #28610, coming from #28610#pullrequestreview-1802823938.

Verifying that the 'replaced_by_txid' and 'replaces_txid' tx data is preserved after migration, as well as the extra tx comments.

test: wallet migration, add coverage for tx extra data

Verifying that the 'replaced_by_txid' and 'replaces_txid'
tx data is preserved after migration, as well as the
extra tx comments.

016cc807f7

DrahtBot commented at 3:05 PM on January 8, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK jamesob, pablomartin4btc, BrandonOdiwuor, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Jan 8, 2024
jamesob commented at 4:32 PM on January 8, 2024: contributor

Nice, ACK https://github.com/bitcoin/bitcoin/pull/29204/commits/016cc807f77a9128d430a0df1edd133521628a33
pablomartin4btc commented at 6:11 PM on January 8, 2024: member

ACK 016cc807f77a9128d430a0df1edd133521628a33
BrandonOdiwuor approved
BrandonOdiwuor commented at 9:24 AM on January 10, 2024: contributor

lgtm ACK 016cc807f77a9128d430a0df1edd133521628a33
achow101 commented at 7:01 PM on January 10, 2024: member

ACK 016cc807f77a9128d430a0df1edd133521628a33
achow101 merged this on Jan 10, 2024
achow101 closed this on Jan 10, 2024
furszy deleted the branch on Feb 3, 2024
bitcoin locked this on Feb 2, 2025