[26.x] more backports #29209

1. 
   glozow commented at 4:02 pm on January 9, 2024: member

   Backports for 26.x. Includes:

   • 453b481 from #28391
     • #29179
   • #29200
   • #29227
   • #28791
   • #29127
2. glozow added the label Backport on Jan 9, 2024
3. 
   DrahtBot commented at 4:02 pm on January 9, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	stickies-v

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. fanquake added this to the milestone 26.1 on Jan 9, 2024
5. DrahtBot added the label CI failed on Jan 9, 2024
6. stickies-v approved
7. 
   stickies-v commented at 12:34 pm on January 16, 2024: contributor

   ACK 234f32860dd0e450e214c93af09e9dd9df20e9ea
8. 
   achow101 commented at 8:04 pm on January 16, 2024: member

   perhaps add #28791
9. 
   stickies-v commented at 11:21 am on January 18, 2024: contributor

   Backports LGTM d055adad985752c5ae3cf9dd0f509c83850e6c5b but it seems that the commit messages are different than usual? It doesn’t seem like we have formal documentation on this, but keeping things uniform helps keep scripts simple (e.g. compiling a list of all pulls that are backported from git log) so this might be worth updating?

   • Rebased-From only mentions the short hash when I think typically we use the full hash (needed for git fetch)
   • Github-Pull uses bitcoin#<number> when I think typically we just use #number (do we ever backport from different repos?)
   • ddfed7a1700df4dc255164dc9a2ecdb05d8441e4 is missing both Rebased-From and Github-Pull
10. glozow force-pushed on Jan 18, 2024
11. 
    glozow commented at 3:10 pm on January 18, 2024: member

    fixed commit messages.
12. 
    fanquake commented at 10:20 am on January 19, 2024: member

    Lets add #29127, so if we decide to, we can test macOS notarization: #15774 (comment).
13. [refactor] Add helper for iterating through mempool entries

    Instead of reaching into the mapTx data structure, use a helper method
    that provides the required vector of CTxMemPoolEntry pointers.
    
    Github-Pull: #28391
    Rebased-From: 453b4813ebc74859864803e9972b58e4be76a4d6

    fc62271015
14. net: create I2P sessions with both ECIES-X25519 and ElGamal encryption

    A Bitcoin Core node may only connect to a peer destination via I2P if both sides
    have sessions with the same encryption type.  The encryption type is a property
    of the session, not the destination.  Sessions may support multiple encryption
    types.
    
    As Bitcoin Core is not currently setting the I2P encryption type when creating
    sessions, it is using the older default, ElGamal (type 0).
    
    This pull updates Bitcoin Core to use both ECIES-X25519 and ElGamal (types 4 and
    0, respectively).  This allows to connect to I2P peers with either type, and the
    newer, faster ECIES-X25519 will be preferred.
    
    See also the recently updated section "Signature and Encryption Types" in
    https://geti2p.net/en/docs/api/samv3
    
    Thanks and credit to zzzi2p (https://github.com/zzzi2p) for reporting.
    
    Closes https://github.com/bitcoin/bitcoin/issues/29197.
    
    Github-Pull: #29200
    Rebased-From: 9d728916b27e18efc6f8839770ed5ec14789fc08

    fe0f8fe8aa
15. [log] mempool loading

    Log at the top before incrementing so that this log isn't printed when
    there's only 1 tx.
    
    Github-Pull: #29227
    Rebased-From: eb78ea4eebfe150bc1746282bfdad6eb0f764e3c

    7ec34554af
16. snapshots: don't core dump when running -checkblockindex after `loadtxoutset`

    Github-Pull: #28791
    Rebased-From: cdc6ac4126b31426261605a757c52ea2dbfb2a81

    438ac2947d
17. [test] rescan legacy wallet with reorged parent + IsFromMe child in mempool

    Test that wallet rescans process transactions topologically, even if a
    parent's entry into the mempool is later than that of its child.
    This behavior is important because IsFromMe requires the ability to look
    up a transaction's inputs.
    
    Github-Pull: #29179
    Rebased-From: c3d02be536ac3f35c10efa03653186a17ebbfc12

    ecb8ebc660
18. [test] import descriptor wallet with reorged parent + IsFromMe child in mempool

    Test that wallet rescans process transactions topologically, even if a
    parent's entry into the mempool is later than that of its child.
    This behavior is important because IsFromMe requires the ability to look
    up a transaction's inputs.
    
    Co-authored-by: furszy <matiasfurszyfer@protonmail.com>
    
    Github-Pull: #29179
    Rebased-From: df30247705940c50c5eaafd74e2abbeb8b0cec07

    ac1b9a51db
19. Use hardened runtime on macOS release builds.

    The Apple notary service requires submitted app bundles to be configured to use the hardened runtime libraries.  This is configured at signing time, and supported by the signapple tool Bitcoin Core uses for reproduceable signed binaries.  We simply need to pass "--hardened-runtime" when the signature is created.  Once attached to the bundle, the resulting codesigned binary can be successfully submitted to the Apple binary notarization service by any Apple Developer.
    
    Github-Pull: #29127
    Rebased-From: 4fdd836db92e789c98b9e68398ca931a968cc9c3

    11f3a7e6ba
20. glozow force-pushed on Jan 19, 2024
21. stickies-v approved
22. 
    stickies-v commented at 4:48 pm on January 19, 2024: contributor

    ACK 11f3a7e6baf145360190635f47b1fb371fb38912
23. fanquake merged this on Feb 16, 2024
24. fanquake closed this on Feb 16, 2024

    ---

25. glozow deleted the branch on Feb 16, 2024

Contributors
glozow DrahtBot stickies-v achow101 fanquake

Labels
Backport CI failed

Milestone
26.1