doc: Assert that assumed-valid blocks are not fully valid in CheckBlockIndex() #29355

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2401-doc-au-fully-valid- changing 2 files +7 −1

maflcko commented at 1:22 PM on January 31, 2024: member

It does not make sense for a block to be fully-valid and assumed-valid at the same time.

Check it in CheckBlockIndex() and fix the tests that violate this assumption.
doc: Assert that assumed-valid blocks are not fully valid in CheckBlockIndex() fa027e08f7
DrahtBot commented at 1:22 PM on January 31, 2024: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK fjahr, ryanofsky

Concept ACK delta1, epiccurious

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #29370 (assumeutxo: Get rid of faked nTx and nChainTx values by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot added the label Docs on Jan 31, 2024
delta1 commented at 10:18 AM on February 2, 2024: none

Concept ACK fa027e08f7be63c201f42d0e06160d2273b4a6dd
epiccurious commented at 2:08 AM on February 11, 2024: contributor

Concept ACK fa027e08f7be63c201f42d0e06160d2273b4a6dd.
fjahr commented at 10:44 PM on February 19, 2024: contributor

Seems reasonable, code review ACK fa027e08f7be63c201f42d0e06160d2273b4a6dd

Not sure why this is marked as a "doc" change though.
delta1 commented at 4:43 AM on February 20, 2024: none

@fjahr i think drahtbot added that label because the commit starts with “doc:”
fjahr commented at 12:35 PM on February 20, 2024: contributor

@fjahr i think drahtbot added that label because the commit starts with “doc:”

Yes, my question is why the "doc" is there in the commit desciption
ryanofsky approved
ryanofsky commented at 4:43 PM on February 21, 2024: contributor

Code review ACK fa027e08f7be63c201f42d0e06160d2273b4a6dd. This change makes sense and is an improvement over the status quo. I think it could be considered it a "doc" change since it is just adding an assert, which is a form of documentation, and not changing actual code. Not sure if that is how "doc" has been used other places, though.

This PR is a little redundant with #29370, which drops the BLOCK_ASSUMED_VALID flag entirely, so there is no way it could conflict with BLOCK_VALID_SCRIPTS. But it makes sense to check for conflicting flags as long as both flags exist.
maflcko commented at 4:47 PM on February 21, 2024: member

This PR is a little redundant with #29370, which drops the BLOCK_ASSUMED_VALID flag entirely, so there is no way it could conflict with BLOCK_VALID_SCRIPTS. But it makes sense to check for conflicting flags as long as both flags exist.

Yeah, makes sense. I forgot to close this pull when the other was opened.
maflcko closed this on Feb 21, 2024
maflcko deleted the branch on Feb 21, 2024
bitcoin locked this on Feb 20, 2025