chain.h
while touching it.
refactor: Fix timedata includes #29361
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2402-timedata-includes- changing 10 files +11 −12-
maflcko commented at 11:50 am on February 1, 2024: memberRemove unused includes. Also, fixup comments, see https://github.com/bitcoin/bitcoin/pull/28956/files#r1464827885. Also, add missing includes to
-
DrahtBot commented at 11:50 am on February 1, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage
For detailed information about the code coverage, see the test coverage report.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK dergoegge, stickies-v, achow101 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #27006 (reduce cs_main scope, guard block index ’nFile’ under a local mutex by furszy)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
DrahtBot added the label Refactoring on Feb 1, 2024
-
stickies-v commented at 12:05 pm on February 1, 2024: contributorConcept ACK, but I think there are a couple more include changes that should be made as per my diff in #28956#pullrequestreview-1838562579
-
refactor: Fix timedata includes fad0fafd5a
-
maflcko force-pushed on Feb 1, 2024
-
DrahtBot added the label CI failed on Feb 1, 2024
-
DrahtBot removed the label CI failed on Feb 1, 2024
-
dergoegge approved
-
dergoegge commented at 9:49 am on February 2, 2024: memberutACK fad0fafd5aca699cfab7673f8eb18211139aeb18
-
DrahtBot requested review from stickies-v on Feb 2, 2024
-
in src/chain.h:1 in fad0fafd5a
stickies-v commented at 11:59 am on February 2, 2024:nit: iwyu suggests
0chain.h should add these lines: 1namespace Consensus { struct Params; } 2 3chain.h should remove these lines: 4- #include <consensus/params.h> // lines 10-10
maflcko commented at 12:28 pm on February 2, 2024:Going to leave removal of further includes to a follow-upstickies-v approvedstickies-v commented at 11:59 am on February 2, 2024: contributorACK fad0fafd5aca699cfab7673f8eb18211139aeb18achow101 commented at 5:02 pm on February 2, 2024: memberACK fad0fafd5aca699cfab7673f8eb18211139aeb18achow101 merged this on Feb 2, 2024achow101 closed this on Feb 2, 2024
maflcko deleted the branch on Feb 3, 2024
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 12:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 12:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me