refactor: Fix timedata includes #29361

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2402-timedata-includes- changing 10 files +11 −12

maflcko commented at 11:50 AM on February 1, 2024: member

Remove unused includes. Also, fixup comments, see https://github.com/bitcoin/bitcoin/pull/28956/files#r1464827885. Also, add missing includes to chain.h while touching it.
DrahtBot commented at 11:50 AM on February 1, 2024: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK dergoegge, stickies-v, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #27006 (reduce cs_main scope, guard block index 'nFile' under a local mutex by furszy)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot added the label Refactoring on Feb 1, 2024
stickies-v commented at 12:05 PM on February 1, 2024: contributor

Concept ACK, but I think there are a couple more include changes that should be made as per my diff in #28956#pullrequestreview-1838562579
refactor: Fix timedata includes fad0fafd5a
maflcko force-pushed on Feb 1, 2024
DrahtBot added the label CI failed on Feb 1, 2024
DrahtBot removed the label CI failed on Feb 1, 2024
dergoegge approved
dergoegge commented at 9:49 AM on February 2, 2024: member

utACK fad0fafd5aca699cfab7673f8eb18211139aeb18
DrahtBot requested review from stickies-v on Feb 2, 2024
in src/chain.h:1 in fad0fafd5a
stickies-v commented at 11:59 AM on February 2, 2024:

nit: iwyu suggests

chain.h should add these lines: namespace Consensus { struct Params; } chain.h should remove these lines: - #include <consensus/params.h> // lines 10-10
maflcko commented at 12:28 PM on February 2, 2024:

Going to leave removal of further includes to a follow-up
stickies-v approved
stickies-v commented at 11:59 AM on February 2, 2024: contributor

ACK fad0fafd5aca699cfab7673f8eb18211139aeb18
achow101 commented at 5:02 PM on February 2, 2024: member

ACK fad0fafd5aca699cfab7673f8eb18211139aeb18
achow101 merged this on Feb 2, 2024
achow101 closed this on Feb 2, 2024
maflcko deleted the branch on Feb 3, 2024
bitcoin locked this on Feb 2, 2025