ci: Avoid CI failures from temp env file reuse #29441

1. 
   maflcko commented at 3:16 PM on February 16, 2024: member

   • Currently, running separate CI tasks at the same time may intermittently fail, because they race to read/write /tmp/env. Fix this by adding $CONTAINER_NAME to the file name.

   • Also, add $USER, while touching the line, to allow different users to run the same CI task at the same time.

   • Also, skip the git install if there is no need.

   Ref: https://github.com/bitcoin/bitcoin/pull/29274

2. ci: vary /tmp/env c65fde4831
3. ci: Skip git install if it is already installed

   This also avoids the sudo requirement for self-hosted CI runners.

   fa91bf2559
4. 
   DrahtBot commented at 3:16 PM on February 16, 2024: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	Sjors, BrandonOdiwuor, hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. DrahtBot added the label Tests on Feb 16, 2024
6. maflcko requested review from Sjors on Feb 16, 2024
7. Sjors approved
8. 
   Sjors commented at 4:07 PM on February 16, 2024: member

   ACK fa91bf2559d2e839592bf1dc1d423d5fb1c3573e

9. BrandonOdiwuor approved
10. 
    BrandonOdiwuor commented at 6:36 PM on February 16, 2024: contributor

    ACK fa91bf2559d2e839592bf1dc1d423d5fb1c3573e

    Looks good to me

11. maflcko added this to the milestone 27.0 on Feb 17, 2024
12. in .cirrus.yml:57 in fa91bf2559

      54 | @@ -55,7 +55,7 @@ base_template: &BASE_TEMPLATE
      55 |    << : *FILTER_TEMPLATE
      56 |    merge_base_script:
      57 |      # Unconditionally install git (used in fingerprint_script).
    

    ---

    ---

    

    hebasto commented at 3:25 PM on February 19, 2024:

    This comment got outdated, no?

    ---

    

    maflcko commented at 3:42 PM on February 19, 2024:

    git is still installed unconditionally, otherwise, it wouldn't be present, no?

    Might replace "install" with "require" if I re-touch, or in a follow-up?

13. hebasto approved
14. 
    hebasto commented at 3:44 PM on February 19, 2024: member

    ACK fa91bf2559d2e839592bf1dc1d423d5fb1c3573e.

15. 
    maflcko commented at 9:00 AM on February 20, 2024: member

    rfm? :)

16. fanquake merged this on Feb 20, 2024
17. fanquake closed this on Feb 20, 2024

    ---

18. maflcko deleted the branch on Feb 20, 2024
19. 
    m3dwards commented at 12:02 PM on February 21, 2024: contributor

    Post merge ACK https://github.com/bitcoin/bitcoin/commit/fa91bf2559d2e839592bf1dc1d423d5fb1c3573e.

    I ran multiple CI jobs at the same time and observed the nicer naming in the /tmp directory.

20. luke-jr referenced this in commit 039c0b5dc5 on Mar 5, 2024
21. luke-jr referenced this in commit bad367a778 on Mar 5, 2024
22. luke-jr referenced this in commit d2f04b2c57 on Mar 13, 2024
23. luke-jr referenced this in commit c1a0981ddb on Mar 13, 2024
24. ryanofsky referenced this in commit 45f757c726 on Jul 10, 2024
25. bitcoin locked this on Feb 20, 2025

Contributors

maflckoDrahtBotSjorsBrandonOdiwuorhebastom3dwards

Milestone
27.0