Added coverage for the addnode rpc when v2transport is not enabled,
but is set as true when calling addnode rpc.
I ran the following to check if this rpc error message
was covered in the functional tests.
grep -nr "v2transport requested but not enabled" ./test/functional --binary-files=without-match
Adds test coverage to this line. https://github.com/bitcoin/bitcoin/blob/master/src/rpc/net.cpp#L339
Added coverage for the addnode rpc when v2transport is not enabled but
is set as true when calling addnode rpc
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | maflcko, brunoerg, BrandonOdiwuor, theStack |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
11 | @@ -12,6 +12,7 @@ 12 | from test_framework.util import ( 13 | assert_equal, 14 | p2p_port, 15 | + assert_raises_rpc_error
assert_raises_rpc_error,
nit (only if you re-touch for other reasons): Please always add the trailing comma, to avoid having to touch this line again in the future when a new item is added to the list. Also, could sort.
lgtm ACK 345169a7523f00209985da88e0171e8687589c25
Checked coverage per https://corecheck.dev/bitcoin/bitcoin/pulls/29460
utACK 345169a7523f00209985da88e0171e8687589c25
Code Review ACK 345169a7523f00209985da88e0171e8687589c25
Code-review ACK 345169a7523f00209985da88e0171e8687589c25