Here is what I have fixed:
http://voorloopnul.com/blog/a-python-netstat-in-less-than-100-lines-of-code/ --> https://web.archive.org/web/20190424172231/http://voorloopnul.com/blog/a-python-netstat-in-less-than-100-lines-of-code/
These links were found with link-inspector. If you find this PR useful, give the repo a ⭐
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | fjahr |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--85328a0da195eb286784d51f73fa0af9-->
🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the documentation.
Possibly this is due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
Leave a comment here, if you need help tracking down a confusing failure.
<sub>Debug: https://github.com/bitcoin/bitcoin/runs/21945394777</sub>
68 | @@ -69,7 +69,7 @@ Translations 69 | ------------ 70 | 71 | Changes to translations as well as new translations can be submitted to 72 | -[Bitcoin Core's Transifex page](https://www.transifex.com/bitcoin/bitcoin/). 73 | +[Bitcoin Core's Transifex page](https://explore.transifex.com/bitcoin/bitcoin/).
The current link works fine for me. It redirects to https://app.transifex.com/bitcoin/bitcoin/dashboard/ or https://explore.transifex.com/bitcoin/bitcoin/ depending on the website cookies content.
It works for me as well, so not absolutely needed to update it.
It works here as well.
If a translator has already logged into their Transifex account, the current link brings them directly to the project dashboard. But the suggested link brings to the project in "explore" mode, and logging in is required to start working on translations.
So I'm NACK about this change.
And could you squash these to one commit, please?
The sub-trees are now unmodified, and everything is squashed into one commit. Thank you for all the help!
ACK c9bf07cc64d10a33754c5f292a13d7d587b37757
The transifex links are not broken for me, so I'm not sure if they need updating. Maybe some browsers have issues with the redirect so it's ok for me to keep the change though.
Given the above discussion, I think the only change that can be made here is the one in netutil.py. So you can either reduce this PR to just that change, or close it.
Given the above discussion, I think the only change that can be made here is the one in
netutil.py. So you can either reduce this PR to just that change, or close it.
Thanks for the feedback. The PR has been updated to only include netutil.pu.
ACK 6fa61e35320ac2bc623a9c9ca11b270b34e2d05a