build: remove -Wdocumentation conditional #29486

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_wdoc_conditional changing 1 files +1 −4

fanquake commented at 9:56 am on February 27, 2024: member

Now that --enable-suppress-external-warnings is on by default, we can drop it. CIs are all already building with this flag.

build: remove -Wdocumentation conditional

Now that --enable-suppress-external-warnings is on by default, we can
drop it.

b052b2d1f2

DrahtBot commented at 9:56 am on February 27, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers

ACK Empact, theuni

Concept ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:
- #25972 (build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set by fanquake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot added the label Build system on Feb 27, 2024
hebasto commented at 10:00 am on February 27, 2024: member

Concept ACK.
maflcko added the label DrahtBot Guix build requested on Feb 27, 2024
Empact approved
Empact commented at 5:23 pm on February 27, 2024: member

Code review ACK https://github.com/bitcoin/bitcoin/pull/29486/commits/b052b2d1f2b220582a933eb5fa6a28144bed07d8
DrahtBot requested review from hebasto on Feb 27, 2024

Type	Reviewers
ACK	Empact, theuni
Concept ACK	hebasto

DrahtBot commented at 7:40 pm on February 27, 2024: contributor

Guix builds (on x86_64)

File	commit 6a7ed5e2374bfea943742595c76da8f2d25061f6(master)	commit f375f29936ae8f7f12353389df2e63c40b46ea07(master and this pull)
SHA256SUMS.part	`1c34f1e5d39e6e9f...`	`fd57f0291d001667...`
*-aarch64-linux-gnu-debug.tar.gz	`24e23354d1be9fc8...`	`38201f9d65fa7e64...`
*-aarch64-linux-gnu.tar.gz	`358ad6c1b0dd8ead...`	`92957d023b9d8d5a...`
*-arm-linux-gnueabihf-debug.tar.gz	`60042e298ffdd3c3...`	`f605239734e19570...`
*-arm-linux-gnueabihf.tar.gz	`fed6a8b2bdf2a303...`	`10104fef58aab5e6...`
*-arm64-apple-darwin-unsigned.tar.gz	`4c9a8d9d5b89a020...`	`35cbe59227fc2595...`
*-arm64-apple-darwin-unsigned.zip	`2cfdf3c5b0a0db30...`	`6fd0a0c58f1527dd...`
*-arm64-apple-darwin.tar.gz	`7960a667b50e1e1f...`	`a82940a47bf5d1a0...`
*-powerpc64-linux-gnu-debug.tar.gz	`25e57cb4560928de...`	`88145d33aeebe163...`
*-powerpc64-linux-gnu.tar.gz	`fccab49cbdd030c6...`	`4b52221298ba695c...`
*-powerpc64le-linux-gnu-debug.tar.gz	`0dad8bf978d0ac93...`	`b85b3037a0d86a4a...`
*-powerpc64le-linux-gnu.tar.gz	`561cdb98080d9fe7...`	`94726f52158ddc2c...`
*-riscv64-linux-gnu-debug.tar.gz	`bf9f2e103904eb7f...`	`eab27dbd0443cbe5...`
*-riscv64-linux-gnu.tar.gz	`4f166d86b4597cbd...`	`d0803315c3ba0b16...`
*-x86_64-apple-darwin-unsigned.tar.gz	`7ed87d2ffa2a3860...`	`2cb461d230465d6d...`
*-x86_64-apple-darwin-unsigned.zip	`999c3327d8d208c2...`	`20caea405f45f757...`
*-x86_64-apple-darwin.tar.gz	`99c857d9cd288193...`	`cc0f850ba2b43239...`
*-x86_64-linux-gnu-debug.tar.gz	`c4aa5e9c880bc333...`	`cd72b289b3d1529e...`
*-x86_64-linux-gnu.tar.gz	`63f3a64c51429d91...`	`f3228f37aa8f7619...`
*.tar.gz	`d9e5a8d2f97b2900...`	`9e712cb5616426a0...`
guix_build.log	`eacd4c991584db23...`	`f2a2b84d78ca976d...`
guix_build.log.diff		`a59cc84c63bcc268...`

DrahtBot removed the label DrahtBot Guix build requested on Feb 27, 2024
theuni approved
theuni commented at 7:47 pm on February 27, 2024: member

utACK b052b2d1f2b220582a933eb5fa6a28144bed07d8
fanquake merged this on Feb 28, 2024
fanquake closed this on Feb 28, 2024
fanquake deleted the branch on Feb 28, 2024

Contributors
fanquake DrahtBot hebasto Empact theuni

Review Requested
hebasto

Labels
Build system

build: remove -Wdocumentation conditional #29486

Code Coverage

Reviews

Conflicts

Guix builds (on x86_64)