depends: add -g to DEBUG=1 flags #29527

1. 
   fanquake commented at 4:36 pm on March 1, 2024: member

   Add -g to the base DEBUG=1 flags in depends. Avoids the need to specify it per-package. More alignment with --enable-debug behaviour in configure.

   We also want to align the optimization flags, currently -O1 vs -O0, however that can be it’s own PR.

2. fanquake requested review from theuni on Mar 1, 2024
3. 
   DrahtBot commented at 4:36 pm on March 1, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	theuni
   Concept ACK	TheCharlatan, hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Build system on Mar 1, 2024
5. 
   theuni commented at 4:45 pm on March 1, 2024: member

   Concept ACK.

   As I’ve mentioned before, I don’t have a strong preference for -O0 vs -O1 vs -Og, but -Og makes the most sense to me.

   More alignment with –enable-debug behaviour in configure. We also want to align the optimization flags, currently -O1 vs -O0, however that can be it’s own PR.

   This I strongly agree with though. Whatever we choose we should use everywhere.

6. 
   theuni commented at 4:48 pm on March 1, 2024: member

   If I recall, the original reason for keeping -g out of here is that it seriously blows up the size of the build, which (at the time) had very real consequences for caching with c-i. Unsure if it’s as big a deal these days?
7. 
   maflcko commented at 10:10 am on March 12, 2024: member

   The CI depends cache is “unlimited” in size, and the CI ccache size can be modified, if needed.
8. 
   TheCharlatan commented at 8:47 pm on March 13, 2024: contributor

   Concept ACK
9. 
   TheCharlatan commented at 9:25 pm on March 13, 2024: contributor

   I get an error in the debug windows build:

    0make HOST=x86_64-w64-mingw32 DEBUG=1 -j 30
    1...
    2Qt Tools:
    3  QDoc ................................... yes
    4
    5Note: Also available for Linux: linux-clang linux-icc
    6
    7Note: Using static linking will disable the use of dynamically
    8loaded plugins. Make sure to import all needed static plugins,
    9or compile needed modules into the library.
   10
   11ERROR: Qt requires a compliant STL library.
   12make: *** [funcs.mk:291: /home/drgrid/bitcoin/depends/x86_64-w64-mingw32/.qt_stamp_configured] Error 3
   

10. 
    hebasto commented at 1:33 pm on March 18, 2024: member

    Concept ACK.

    Add -g to the base DEBUG=1 flags in depends. More alignment with --enable-debug behaviour in configure.

    Why not -g3 then? https://github.com/bitcoin/bitcoin/blob/015ac13dcc964a31ef06dfdb565f88f901607f0e/configure.ac#L353

11. 
    fanquake commented at 1:34 pm on March 18, 2024: member

    Why not -g3 then?

    Because we aren’t testing, and -g always works.

12. 
    fanquake commented at 2:16 pm on March 26, 2024: member

    I get an error in the debug windows build:

    Looks like that error is unrelated to the changes here, and instead the Windows Qt DEBUG=1 build is just broken on master.

13. fanquake referenced this in commit b7e7e727ab on Mar 27, 2024
14. fanquake force-pushed on Mar 27, 2024
15. 
    fanquake commented at 11:02 am on March 27, 2024: member

    Looks like that error is unrelated to the changes here, and instead the Windows Qt DEBUG=1 build is just broken on master.

    Reabsed on a commit that fixes this.

16. fanquake referenced this in commit 7a12cbed99 on Mar 27, 2024
17. fanquake force-pushed on Mar 27, 2024
18. fanquake force-pushed on Apr 1, 2024
19. DrahtBot added the label CI failed on Apr 1, 2024
20. depends: add -g to DEBUG=1 flags eef51afc6a
21. depends: remove -g from sqlite debug flags 84fbf9b284
22. fanquake force-pushed on Apr 2, 2024
23. theuni approved
24. 
    theuni commented at 4:33 pm on April 2, 2024: member

    ACK 84fbf9b2841a9ba1ebd1421b9ff9fe444bb1abd9
25. DrahtBot requested review from TheCharlatan on Apr 2, 2024
26. DrahtBot requested review from hebasto on Apr 2, 2024
27. fanquake merged this on Apr 3, 2024
28. fanquake closed this on Apr 3, 2024

    ---

29. fanquake deleted the branch on Apr 3, 2024
30. 
    fanquake commented at 9:46 am on April 3, 2024: member

    Going to followup with an optimization flags alingment RFC.

Contributors
fanquake DrahtBot theuni maflcko TheCharlatan hebasto

Review Requested
TheCharlatan hebasto

Labels
Build system CI failed