doc: update NeedsRedownload() and nStatus comment #29624

1. 
   Sjors commented at 7:32 PM on March 11, 2024: member

   Noticed two outdated comments while reviewing #29370.

   Since #21009 we no longer roll back the chain, when a user updates a pre-segwit node to a modern node. In this unlikely scenario we tell the user to -reindex.

   This PR updates a comment in PopulateAndValidateSnapshot to reflect that change. Ditto for the description of nStatus in chain.h.

2. 
   DrahtBot commented at 7:32 PM on March 11, 2024: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko, fjahr

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Docs on Mar 11, 2024
4. Sjors force-pushed on Mar 12, 2024
5. Sjors renamed this:
   doc: update NeedsRedownload() comment
   doc: update NeedsRedownload() and nStatus comment
   on Mar 12, 2024
6. hernanmarino approved
7. 
   maflcko commented at 10:17 AM on April 10, 2024: member

   lgtm ACK 6cfac2c9094cdb2cc35efa72adef60063693fbfe

   I did not test this, to confirm the error message.

8. DrahtBot added the label CI failed on Sep 11, 2024
9. DrahtBot removed the label CI failed on Sep 15, 2024
10. doc: update NeedsRedownload() comment af9f987893
11. Sjors force-pushed on Sep 17, 2024
12. 
    Sjors commented at 7:55 AM on September 17, 2024: member

    Just the bi-annual rebase the doctor asked for :-)

    cc @ryanofsky @fjahr

13. 
    maflcko commented at 8:18 AM on September 17, 2024: member

    re-ACK af9f9878934f88036423021c70ef523b6c9e1c90

14. maflcko requested review from fjahr on Sep 17, 2024
15. maflcko requested review from ryanofsky on Sep 17, 2024
16. 
    fjahr commented at 12:52 PM on September 17, 2024: contributor

    ACK af9f9878934f88036423021c70ef523b6c9e1c90

17. fanquake merged this on Sep 17, 2024
18. fanquake closed this on Sep 17, 2024

    ---

19. Sjors deleted the branch on Sep 17, 2024
20. TheCharlatan referenced this in commit 8bb47d4c2c on Nov 2, 2024
21. bitcoin locked this on Sep 17, 2025

Contributors

SjorsDrahtBothernanmarinomaflckofjahr

Review Requested
fjahrryanofsky