error()
that was missed in a comment.
log: Remove error() reference #29633
pull fjahr wants to merge 1 commits into bitcoin:master from fjahr:2024-03-error-cleanup changing 1 files +1 −1-
fjahr commented at 1:41 pm on March 12, 2024: contributorMini-followup to #29236 that was just merged. Removes a reference to
-
DrahtBot commented at 1:41 pm on March 12, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage
For detailed information about the code coverage, see the test coverage report.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK ryanofsky, stickies-v, Empact If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
DrahtBot added the label Utils/log/libs on Mar 12, 2024
-
in src/logging.h:218 in 1ebcd43f5b outdated
214@@ -215,7 +215,7 @@ static inline bool LogAcceptCategory(BCLog::LogFlags category, BCLog::Level leve 215 /** Return true if str parses as a log category and set the flag */ 216 bool GetLogCategory(BCLog::LogFlags& flag, const std::string& str); 217 218-// Be conservative when using LogPrintf/error or other things which 219+// Be conservative when using LogPrintf or other things which
maflcko commented at 1:50 pm on March 12, 2024:LogPrintf
is deprecated, according to the dev notes, so when touching this line, it could be fixed up as well, to avoid having to touch this again, soon after.
ryanofsky commented at 2:48 pm on March 12, 2024:re: #29633 (review)
LogPrintf
is deprecated, according to the dev notes, so when touching this line, it could be fixed up as well, to avoid having to touch this again, soon after.FWIW #29256 just deletes this comment, which is not near any of the logging functions and I doubt anyone will see. It is replaced by documentation for the new logging macros.
fjahr commented at 3:30 pm on March 12, 2024:I have removed the
LogPrintf
reference as well.FWIW #29256 just deletes this comment
Cool! If that was further along I would simply drop this PR here but I am not clear if the discussion there is fully resolved yet. So I am keeping this open for now but if this stays open longer and #29256 collects ACKs, feel free to close it.
ryanofsky approvedryanofsky commented at 2:50 pm on March 12, 2024: contributorCode review ACK 1ebcd43f5b081e1fb8ad7c33b99321ba137dcbb2log: Remove error() reference d0e6564240fjahr force-pushed on Mar 12, 2024maflcko approvedmaflcko commented at 3:31 pm on March 12, 2024: memberlgtm, thanks!
Could cross-link to the dev notes, if you re-touch.
ryanofsky approvedryanofsky commented at 4:25 pm on March 12, 2024: contributorCode review ACK d0e6564240857994db53d06f66ea09da0edbaf0f. Just dropped LogPrintf reference since last reviewstickies-v approvedstickies-v commented at 4:51 pm on March 12, 2024: contributorACK d0e6564240857994db53d06f66ea09da0edbaf0fEmpact approvedEmpact commented at 6:12 pm on March 12, 2024: memberfanquake merged this on Mar 12, 2024fanquake closed this on Mar 12, 2024
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-31 03:12 UTC
More mirrored repositories can be found on mirror.b10c.me