log: Remove error() reference #29633

1. 
   fjahr commented at 1:41 pm on March 12, 2024: contributor

   Mini-followup to #29236 that was just merged. Removes a reference to error() that was missed in a comment.
2. 
   DrahtBot commented at 1:41 pm on March 12, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	ryanofsky, stickies-v, Empact

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Utils/log/libs on Mar 12, 2024
4. in src/logging.h:218 in 1ebcd43f5b outdated

   214@@ -215,7 +215,7 @@ static inline bool LogAcceptCategory(BCLog::LogFlags category, BCLog::Level leve
   215 /** Return true if str parses as a log category and set the flag */
   216 bool GetLogCategory(BCLog::LogFlags& flag, const std::string& str);
   217 
   218-// Be conservative when using LogPrintf/error or other things which
   219+// Be conservative when using LogPrintf or other things which
   

   ---

   ---

   

   maflcko commented at 1:50 pm on March 12, 2024:

   LogPrintf is deprecated, according to the dev notes, so when touching this line, it could be fixed up as well, to avoid having to touch this again, soon after.

   ---

   

   ryanofsky commented at 2:48 pm on March 12, 2024:

   re: #29633 (review)

   LogPrintf is deprecated, according to the dev notes, so when touching this line, it could be fixed up as well, to avoid having to touch this again, soon after.

   FWIW #29256 just deletes this comment, which is not near any of the logging functions and I doubt anyone will see. It is replaced by documentation for the new logging macros.

   ---

   

   fjahr commented at 3:30 pm on March 12, 2024:

   I have removed the LogPrintf reference as well.

   FWIW #29256 just deletes this comment

   Cool! If that was further along I would simply drop this PR here but I am not clear if the discussion there is fully resolved yet. So I am keeping this open for now but if this stays open longer and #29256 collects ACKs, feel free to close it.

5. ryanofsky approved
6. 
   ryanofsky commented at 2:50 pm on March 12, 2024: contributor

   Code review ACK 1ebcd43f5b081e1fb8ad7c33b99321ba137dcbb2
7. log: Remove error() reference d0e6564240
8. fjahr force-pushed on Mar 12, 2024
9. maflcko approved
10. 
    maflcko commented at 3:31 pm on March 12, 2024: member

    lgtm, thanks!

    Could cross-link to the dev notes, if you re-touch.

11. ryanofsky approved
12. 
    ryanofsky commented at 4:25 pm on March 12, 2024: contributor

    Code review ACK d0e6564240857994db53d06f66ea09da0edbaf0f. Just dropped LogPrintf reference since last review
13. stickies-v approved
14. 
    stickies-v commented at 4:51 pm on March 12, 2024: contributor

    ACK d0e6564240857994db53d06f66ea09da0edbaf0f
15. Empact approved
16. 
    Empact commented at 6:12 pm on March 12, 2024: member

    ACK https://github.com/bitcoin/bitcoin/pull/29633/commits/d0e6564240857994db53d06f66ea09da0edbaf0f
17. fanquake merged this on Mar 12, 2024
18. fanquake closed this on Mar 12, 2024

    ---

Contributors
fjahr DrahtBot maflcko ryanofsky stickies-v Empact

Labels
Utils/log/libs